Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Release the camera stream used to request video and audio permissions #4342

Merged
merged 8 commits into from
Sep 16, 2021
Merged

[camera_web] Release the camera stream used to request video and audio permissions #4342

merged 8 commits into from
Sep 16, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Sep 14, 2021

The camera stream used to request video and audio permissions is now released before accessing available camera devices. This solves a cameraNotReadable error thrown when requesting a camera stream that is already in use.

Fixes flutter/flutter#90040.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe
Copy link
Contributor Author

bselwe commented Sep 14, 2021

@ditman

@google-cla

This comment has been minimized.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 16, 2021
@ditman
Copy link
Member

ditman commented Sep 16, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 16, 2021
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had discussed this a couple of weeks ago. LGTM!

@ditman ditman added waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. labels Sep 16, 2021
@ditman
Copy link
Member

ditman commented Sep 16, 2021

(Making this PR a NEXT release, so it can be published alongside #4210)

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 16, 2021
@fluttergithubbot fluttergithubbot merged commit c13218f into flutter:master Sep 16, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 18, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: camera platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[camera_web] cameraNotReadable error prevents access to the camera on some Android devices
3 participants