-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM (with one question), since this key isn't documented at https://github.com/flutter/cocoon/blob/master/CI_YAML.md so I'm not entirely sure what it does. (Could it be added there?)
@@ -39,6 +39,7 @@ targets: | |||
recipe: plugins/plugins | |||
timeout: 30 | |||
properties: | |||
add_recipes_cq: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want the string true, not the value true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out! I'll add it to the docs.
This is a limitation of yaml files backed by proto (we define properties to be Map<String, String> as there's no Map<String, dynamic> option (granted we could do a JsonString of sorts)
This enables testing flutter/recipes changes to these builders
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).