Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Ensure seekTo is not called before video player is initialized. #4300

Merged
merged 15 commits into from
Sep 2, 2021
Merged

[video_player] Ensure seekTo is not called before video player is initialized. #4300

merged 15 commits into from
Sep 2, 2021

Conversation

KyleFin
Copy link
Contributor

@KyleFin KyleFin commented Sep 2, 2021 •
edited
Loading

Ensure seekTo doesn't call platform if video player isn't initialized.

Fixes flutter/flutter#89259 (regression due to #3727)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

KyleFin and others added 14 commits March 17, 2021 22:31
@KyleFin
Fix flutter/flutter#77674
fd4b230
@KyleFin
Add unit tests.
2c88d48
@KyleFin
Add unit tests.
be0bd21
@KyleFin
Merge remote-tracking branch 'origin/master'
f44ace0
@KyleFin
dartfmt
deaae24
@KyleFin
Update play() documentation.
60a6595
@KyleFin
Update test cases to use integration_tests.
46af8d4
@KyleFin
Restoring main fork branch to fetch from upstream (will create a ne…
3c8d958 
…w video_player_pause_on_complete remote branch in my fork).
@KyleFin
Restoring main fork branch to fetch from upstream (will create a ne…
5a66567 
…w video_player_pause_on_complete remote branch in my fork).
@KyleFin
Restoring main fork branch to fetch from upstream (will create a ne…
f6338a6 
…w video_player_pause_on_complete remote branch in my fork).
@KyleFin
Merge branch 'flutter:master' into main
40df910
@KyleFin
Ensure seekTo isn't called before video player is initialized. Fixes …
ace08de 
…[#89259](flutter/flutter#89259).
@KyleFin
Merge remote-tracking branch 'origin/main'
0fec24b
@KyleFin
Restore newlines at end of file.
bfbea43
@google-cla google-cla bot added the cla: yes label Sep 2, 2021
@KyleFin KyleFin mentioned this pull request Sep 2, 2021
Closed
@jerryzhoujw jerryzhoujw mentioned this pull request Sep 2, 2021
Closed
11 tasks
stuartmorgan
stuartmorgan approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, and nice refactor :) One small nit, but LGTM.

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 2, 2021
@fluttergithubbot fluttergithubbot merged commit 6f037b4 into flutter:master Sep 2, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
ce2a9cc 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
ffc6017 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
dd3c845 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
38b97db 
…r is initialized. (flutter/plugins#4300)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
9efb41f 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
0c2a78a 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
251f7fe 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
13ed618 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
4e8db95 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
ad03018 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
ebf4c09 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
b87b4f3 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
5cb9203 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
22143c8 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
dd44eeb 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
b1f4487 
…r is initialized. (flutter/plugins#4300)
@jmagman jmagman mentioned this pull request Sep 9, 2021
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
ef51243 
…r is initialized. (flutter/plugins#4300)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
6f037b4 [video_player] Ensure seekTo is not called before video playe…
24ffa4a 
…r is initialized. (flutter/plugins#4300)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@KyleFin @fotiDim
[video_player] Ensure seekTo is not called before video player is ini…
196a207 
…tialized. (flutter#4300)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@KyleFin @amantoux
[video_player] Ensure seekTo is not called before video player is ini…
87c0c48 
…tialized. (flutter#4300)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
cla: yes p: video_player waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@KyleFin @stuartmorgan @fluttergithubbot