Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker]Android update cache #4124

Merged
merged 35 commits into from
Sep 1, 2021
Merged

[image_picker]Android update cache #4124

merged 35 commits into from
Sep 1, 2021

Conversation

ydag
Copy link
Contributor

@ydag ydag commented Jul 1, 2021 •
edited
Loading

This PR updates the ImagePickerCache to cache multiple files.

Related issues :

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ydag added 10 commits June 30, 2021 15:34
@ydag
Add multiRetrieve method call
df341db
@ydag
Refactor finishWithSuccess to cache list of images
2d1a871 
I removed the finishWithListSuccess method since it was a temporary solution to save only the last image when multiple images are picked. With the new implementation of caching, finishWithSuccess method save always a list of images to the cache.
@ydag
Refactor retrieveLostImage method
30a067f 
Since we are saving always a list of images getCacheMap will return pathList by using the new MAP_KEY_PATH_LIST key. But to avoid breaking change, we are also returning MAP_KEY_PATH with the first element of the list.
@ydag
Add new MAP_KEY_PATH_LIST key
01ad85e
@ydag
Refactor saveTypeWithMethodCallName
5a9e99f
@ydag
Update saveResult method
364c79d 
I updated saveResult method to use putStringSet method for saving list of images to the cache.
@ydag
Update the getCacheMap method
757da4c
@ydag
Add statement to return null
3418641
@ydag
Merge branch 'master' into image_picker/android_update_cache
74f3990
@ydag
Update CHANGELOG and version number
93de29f
@ydag ydag requested a review from cyanglaz as a code owner July 1, 2021 09:12
@google-cla google-cla bot added the cla: yes label Jul 1, 2021
ydag added 3 commits July 1, 2021 12:57
@ydag
Revert "Refactor finishWithSuccess to cache list of images"
9264ad9 
This reverts commit 2d1a871.

# Conflicts:
#	packages/image_picker/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java
@ydag
Refactor finishWithSuccess method
e585603
@ydag
Update dependency version
33fb183
@ydag ydag requested a review from renefloor July 1, 2021 12:59
ydag added 4 commits July 16, 2021 15:15
@ydag
Merge branch 'master' into image_picker/android_update_cache
226ef21 
# Conflicts:
#	packages/image_picker/image_picker/CHANGELOG.md
#	packages/image_picker/image_picker/pubspec.yaml
@ydag
Update version and CHANGELOG
ec4079e
@ydag
Add unit tests
a675352
@ydag
Update CHANGELOG
91fd73d
@ydag ydag marked this pull request as draft July 16, 2021 14:12
BeMacized
BeMacized suggested changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@BeMacized BeMacized left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at this one again once the platform interface changes are merged, but already two nits below as they were also in the other PR.

ydag added 2 commits August 20, 2021 09:35
@ydag
Remove unit tests from deprecated LostData
c38ad2b
@ydag
Remove redundant unit test
27f87ca 
This test is removed because `multiRetrieved` method call was removed.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
4726000
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
32ed007
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
4299c5e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
922990b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
d4b10b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
d240520
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
6e962e9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
a828f99
@madsane29 madsane29 mentioned this pull request Sep 9, 2021
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
ea6b877
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
8d7dffc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
158f052
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
4fdbedb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
a8c002e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
@engine-flutter-autoroll
9ef18bc [image_picker]Android update cache (flutter/plugins#4124)
6704608
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@ydag @fotiDim
[image_picker]Android update cache (flutter#4124)
3e6badc
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@ydag @amantoux
[image_picker]Android update cache (flutter#4124)
8220748
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BeMacized BeMacized BeMacized approved these changes

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@renefloor renefloor Awaiting requested review from renefloor

Assignees
No one assigned
Labels
cla: yes p: image_picker platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[image_picker] Update the cache on Android
5 participants
@ydag @BeMacized @mvanbeusekom @renefloor @fluttergithubbot