-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[local_auth] Update and migrate iOS example project #2097
Conversation
Does a change to the example app require a build suffix version bump? |
Yes, I believe so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All the changes are generated by the migrator, is that right?
Some of them are.
flutter migration.
CocoaPods migration after flutter_assets is removed.
Xcode migration.
Xcode migration.
Xcode migration.
I manually removed this. The user of these examples shouldn't be expected to be logged into any particular account or have any particular Flutter development provisioning profiles installed.
Xcode migration.
CocoaPods migration. |
We checked in the ios generated code as it was, is your work a way to remove these extra output automatically? |
Except for removing DEVELOPMENT_TEAM, these changes were all automatic migrations either from the Flutter tool, Xcode, or CocoaPods. I wanted to avoid having changes in the working copy every time I ran the example app. |
Description
pod install
so flutter_assets is removed from the asset copy build phaseRelated Issues
Get to a buildable baseline so I can start working on flutter/flutter#41007.
Checklist
///
).flutter analyze
) does not report any problems on my PR.Breaking Change