Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Update and migrate iOS example project #2097

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Sep 25, 2019

Description

  1. Let Move flutter_assets to App.framework flutter#26630 flutter_assets migrator run
  2. Run pod install so flutter_assets is removed from the asset copy build phase
  3. Migrate deprecated "English" to "en" language
  4. Allow Xcode to remove extraneous xcconfigs, see Remove xcconfigs from template Copy Bundle Resources build phases flutter#38724
  5. Let Xcode 11 update build settings
  6. Remove DEVELOPMENT_TEAM references since having those provisioning profiles should not be required to run the examples (most examples don't have one)
  7. Remove ARCHS, which was causing a compilation error
  8. Remove extraneous framework outputs Multiple commands produce '/build/ios/Debug-iphonesimulator/Runner.app/Frameworks/Flutter.framework flutter#20685

Related Issues

Get to a buildable baseline so I can start working on flutter/flutter#41007.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jmagman
Copy link
Member Author

jmagman commented Sep 25, 2019

Does a change to the example app require a build suffix version bump?

@digiter
Copy link
Contributor

digiter commented Sep 25, 2019

Does a change to the example app require a build suffix version bump?

Yes, I believe so.

Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

All the changes are generated by the migrator, is that right?

@digiter digiter changed the title [local_auth] Update and migrate iOS example project [local_auth][instrumentation_adapter] Update and migrate iOS example project Sep 25, 2019
@jmagman jmagman changed the title [local_auth][instrumentation_adapter] Update and migrate iOS example project [local_auth] Update and migrate iOS example project Sep 25, 2019
@jmagman
Copy link
Member Author

jmagman commented Sep 26, 2019

All the changes are generated by the migrator, is that right?

Some of them are.

  1. Let flutter/flutter#26630 flutter_assets migrator run

flutter migration.

  1. Run pod install so flutter_assets is removed from the asset copy build phase

CocoaPods migration after flutter_assets is removed.

  1. Migrate deprecated "English" to "en" language

Xcode migration.

  1. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724

Xcode migration.

  1. Let Xcode 11 update build settings

Xcode migration.

  1. Remove DEVELOPMENT_TEAM references since having those provisioning profiles should not be required to run the examples (most examples don't have one)

I manually removed this. The user of these examples shouldn't be expected to be logged into any particular account or have any particular Flutter development provisioning profiles installed.

  1. Remove ARCHS, which was causing a compilation error

Xcode migration.

  1. Remove extraneous framework outputs flutter/flutter#20685

CocoaPods migration.

@digiter
Copy link
Contributor

digiter commented Sep 26, 2019

We checked in the ios generated code as it was, is your work a way to remove these extra output automatically?

@jmagman
Copy link
Member Author

jmagman commented Sep 27, 2019

We checked in the ios generated code as it was, is your work a way to remove these extra output automatically?

Except for removing DEVELOPMENT_TEAM, these changes were all automatic migrations either from the Flutter tool, Xcode, or CocoaPods. I wanted to avoid having changes in the working copy every time I ran the example app.

@jmagman jmagman merged commit 2351720 into flutter:master Sep 30, 2019
@jmagman jmagman deleted the build-la branch September 30, 2019 17:46
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants