-
Notifications
You must be signed in to change notification settings - Fork 9.8k
firebase_admob exclude translatesAutoresizingMaskIntoConstraints = NO under ios 11 #1631
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Sure . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
May I know when this PR will be merged? It's quite bothering that I have to apply this change locally in order to have a workable plugin for my app. |
Same! Hoping for a review and release soon. 🤞 |
Maybe this will get some attention if you add |
Tagging @collinjackson to make sure this doesn't fall through the cracks. Thanks! |
Thanks for suggestions i changed to start of title @westy92 also i am tagging to @collinjackso n. |
I've migrated this PR to the new repo: firebase/flutterfire#45 |
Description
AdView be placed with frame location under ios 11. But translatesAutoresizingMaskIntoConstraints has NO flag.
Related Issues
flutter/flutter#27457
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?