Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router_builder]: Fixes issue when using query parameters that caused a nullable error #8753

Closed
wants to merge 1 commit into from

Conversation

Karibash
Copy link

The impact of #8405 caused a build error when defining a route with a required value.

Fixed: flutter/flutter#164358

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Karibash Karibash requested a review from chunhtai as a code owner February 28, 2025 05:12
Copy link

google-cla bot commented Feb 28, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Karibash
Copy link
Author

I get an error when I try to sign the CLA, what should I do?
スクリーンショット 2025-02-28 14 16 05

@Karibash Karibash force-pushed the bugfix/nullable-exception branch from 78e9e4b to 5f7553a Compare February 28, 2025 05:22
@Karibash
Copy link
Author

Karibash commented Mar 1, 2025

Closing this as it is a duplicate of #8737.

@Karibash Karibash closed this Mar 1, 2025
@Karibash Karibash deleted the bugfix/nullable-exception branch March 1, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant