Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_sign_in] Add Android account name field as optional (platform interface changes) #8735

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

neilself
Copy link

@neilself neilself commented Feb 28, 2025

This PR contains the platform interface changes for the main PR 8573. As a whole, these changes add a new option to explicitly specify the account name on Android while signing in within the google_sign_in package.

Flutter issue: 163257

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@neilself neilself changed the title [google_sign_in_platform_interface] Add Android account name field as optional [google_sign_in] Add Android account name field as optional (platform interface changes) Feb 28, 2025
@neilself neilself marked this pull request as ready for review February 28, 2025 02:18
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 for second approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants