-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigeon] Update analyzer and formatter #8456
Conversation
Adds compatibility with the latest major version of `analyzer` and `dart_style` (the latter being required to actually allow `analyzer` 7). The breaking change of `dart_style` does affect our usage, so this updates rather than expands the allowed version. The range for `analyzer` is updated to drop versions older thas 6 since `dart_style` doesn't allow versions older than 6 anyway. We have to pick a language version to use for formatting; this (somewhat arbitrarily) uses 3.6, to opt in to the new formatter. Fixes flutter/flutter#161820 Fixes flutter/flutter#161583
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
text-exempt: updating dependencies |
I'm assuming you ran the generators and nothing changed? |
Just a note, if you want to opt in to the new formatter, you'll need a language version of 3.7 or later, not 3.6. |
In theory CI would catch that, but I'll double-check that I did run it locally before I land.
Ah, right, I was thinking of the wrong roller that gave us issues. I'll stick with 3.6 to match current stable. |
Verified locally. Of course, we run everything through the formatter after we generate, so I can't swear the format of the raw output didn't change. But if it did, it shouldn't matter anyway, since it's just formatted to be something other than one giant line, not for some exact output format. |
flutter/packages@f73cb00...e8f1f63 2025-01-20 [email protected] [in_app_purchase] Update Play Billing library to 7.1.1 (flutter/packages#8218) 2025-01-20 [email protected] Roll Flutter from 5517cc9 to b9e86a5 (22 revisions) (flutter/packages#8458) 2025-01-18 [email protected] [pigeon] Update analyzer and formatter (flutter/packages#8456) 2025-01-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 3 directories with 1 update (flutter/packages#8328) 2025-01-17 [email protected] [local_auth_darwin] Handle when FaceID hardware is available but permissions have been denied for the app (flutter/packages#8348) 2025-01-16 [email protected] Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter/packages#8441) 2025-01-15 [email protected] [in_app_purchase_storekit] expose `jsonRepresentation` for Transactions (flutter/packages#8430) 2025-01-15 [email protected] Roll Flutter (stable) from 17025dd to 68415ad (4 revisions) (flutter/packages#8434) 2025-01-15 [email protected] [video_player_avfoundation] fix playback speed resetting (flutter/packages#7657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds compatibility with the latest major version of
analyzer
anddart_style
(the latter being required to actually allowanalyzer
7).The breaking change of
dart_style
does affect our usage, so this updates rather than expands the allowed version. The range foranalyzer
is updated to drop versions older thas 6 sincedart_style
doesn't allow versions older than 6 anyway.We have to pick a language version to use for formatting; this (somewhat arbitrarily) uses 3.6, to opt in to the new formatter.
Fixes flutter/flutter#161820
Fixes flutter/flutter#161583
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).