[camera] Remove OCMock from CameraExposureTests and CameraFocusTests #8351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraExposureTests.m
Outdated
Show resolved
Hide resolved
|
CC @LouiseHsu who recently did a pretty big swift migration for in-app purchase plugin. |
mchudy
force-pushed
the
feature/camera-ocmock-refactoring-part2
branch
2 times, most recently
from
e7d6b59 to
c597ad3
Compare
|
I'm not sure why the CI build fails. Locally it builds successfully. Do you have any tip maybe what can be the cause of this issue? |
it's been a while since i touched this, but it sounds like either module map or umbrella header. I'd look into a similar header and see how it is setup. |
hellohuanlin
approved these changes
Dec 30, 2024
|
I don't find a 2nd reviewer from the CODEOWNER for this plugin. Maybe @LouiseHsu who recently did a similar swift migration? |
mchudy
force-pushed
the
feature/camera-ocmock-refactoring-part2
branch
from
840af1d to
8256579
Compare
mchudy
force-pushed
the
feature/camera-ocmock-refactoring-part2
branch
8 times, most recently
from
d65a805 to
04f1e8b
Compare
|
I fixed the CI, kind of a workaround (for some reason I cannot get this to work with subfolders). I'm gonna try to fix that in further PRs, but I don't want to block this one. |
11 tasks
mchudy
force-pushed
the
feature/camera-ocmock-refactoring-part2
branch
from
04f1e8b to
d4c4f3a
Compare
stuartmorgan
requested changes
Jan 15, 2025
...dation/Sources/camera_avfoundation/include/camera_avfoundation/FLTCaptureDeviceControlling.h
Show resolved
Hide resolved
...dation/Sources/camera_avfoundation/include/camera_avfoundation/FLTCaptureDeviceControlling.h
Show resolved
Hide resolved
...dation/Sources/camera_avfoundation/include/camera_avfoundation/FLTCaptureDeviceControlling.h
Show resolved
Hide resolved
...tion/Sources/camera_avfoundation/include/camera_avfoundation/FLTDeviceOrientationProviding.h
Show resolved
Hide resolved
...ages/camera/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/FLTCam.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/MockDeviceOrientationProvider.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/MockCaptureDeviceController.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/MockCaptureDeviceController.h
Show resolved
Hide resolved
mchudy
force-pushed
the
feature/camera-ocmock-refactoring-part2
branch
from
81fe294 to
0670369
Compare
mchudy
force-pushed
the
feature/camera-ocmock-refactoring-part2
branch
from
0670369 to
e3f1afd
Compare
packages/camera/camera_avfoundation/example/ios/RunnerTests/MockCaptureDeviceController.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/MockCaptureDeviceController.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/MockCaptureDeviceController.m
Outdated
Show resolved
Hide resolved
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 27, 2025
flutter/packages@3d3ab7b...258f6dc 2025-01-24 [email protected] [shared_preferences] Add shared preferences devtool (flutter/packages#8494) 2025-01-24 [email protected] [shared_preferences] update List<String> encode/decode (flutter/packages#8335) 2025-01-24 [email protected] Manual roll Flutter from c1561a4 to c1ffaa9 (21 revisions) (flutter/packages#8498) 2025-01-24 [email protected] [ios_platform_images] Switch to `loadImage` (flutter/packages#8216) 2025-01-24 [email protected] [camera] Remove OCMock from CameraExposureTests and CameraFocusTests (flutter/packages#8351) 2025-01-24 [email protected] [shared_preferences] Tool for migrating from legacy shared_preferences to shared_preferences_async (flutter/packages#8229) 2025-01-23 [email protected] Revert "[shared_preferences] Add shared preferences devtool" (flutter/packages#8493) 2025-01-23 [email protected] [go_router] Fix return type of current state getter to be non-nullable (flutter/packages#8173) 2025-01-23 [email protected] Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (flutter/packages#8491) 2025-01-23 [email protected] [pigeon] fixes event channel dart instance name usage and adds test (flutter/packages#8483) 2025-01-23 [email protected] [go _route] fragment parameter added (flutter/packages#8232) 2025-01-23 [email protected] [in_app_purchase] Update in_app_purchase_android version in in_app_purchase (flutter/packages#8463) 2025-01-23 [email protected] [image_picker] Reference alternate macOS implementations (flutter/packages#8487) 2025-01-23 [email protected] [rfw] Activate leak testing (flutter/packages#8370) 2025-01-23 [email protected] [video_player] Activate leak testing (flutter/packages#8379) 2025-01-23 [email protected] Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (flutter/packages#8482) 2025-01-23 [email protected] [camera] Add API support query for image streaming (app-facing) (flutter/packages#8422) 2025-01-23 [email protected] Manual roll Flutter from b9e86a5 to eb6af3d (13 revisions) (flutter/packages#8473) 2025-01-23 [email protected] [shared_preferences] Add shared preferences devtool (flutter/packages#8322) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
…ests and ThreadSafeEventChannelTests (#8363) Follow-up on #8342. This should be merged after #8351 - Removes OCMock dependency in `AvailableCamerasTests.m`, `CameraOrientationTests.m` and `ThreadSafeEventChannelTests.m` - Introduces new protocol wrappers to enable mocking `FLTEventChannel` and `FLTCameraDeviceDiscovering`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #8342 to keep PRs smaller
FLTDeviceOrientationProvidingandFLTCaptureDeviceControllingprotocolsOCMock.hreference fromCameraExposureTests.handCameraFocusTests.hPre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.