[video_player_web] Don't modify volume when muting video #7845
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for the contribution! Please add a test for this case! This test is probably going to break: |
|
You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the checklist reflects the state of the PR as posted please feel free to mark it as ready for review. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm unsure why the tree status is failing. I've tried formatting, but it didn't resolve the issue. Do I need to update the CHANGELOG.md for this change, or is it exempt from versioning? |
You do need to update the pubspec and CHANGELOG version, since this is changing a user-facing feature, and it needs to be published to pub.dev. |
ditman
changed the title
|
auto label is removed for flutter/packages/7845, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
auto-submit
bot
removed
the
autosubmit
|
Ah woops, we need a second reviewer! I'll find someone! |
flutter/packages@e0c4f55...028027e 2024-10-29 [email protected] [various] Remove multiDexEnabled (flutter/packages#7956) 2024-10-28 [email protected] Roll Flutter from 5a11904 to 3fb95c7 (16 revisions) (flutter/packages#7948) 2024-10-28 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMACompanionAdSlot` and `IMACompanionDelegate` (flutter/packages#7889) 2024-10-27 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.1 to 4.2.2 (flutter/packages#7919) 2024-10-26 [email protected] Roll Flutter from 4faa4a4 to 5a11904 (67 revisions) (flutter/packages#7937) 2024-10-25 [email protected] Drop deprecated web library (flutter/packages#7926) 2024-10-25 [email protected] [video_player_web] Don't modify volume when muting video (flutter/packages#7845) 2024-10-25 [email protected] Roll Flutter (stable) from 2663184 to 6031040 (3 revisions) (flutter/packages#7930) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Modifies the
setVolumefunction for video elements to properly handle muting without resetting the volume.When the volume is set to 0.0, the video is muted without changing the volume itself, preventing issues with unmuting in certain browsers (like Chrome with Tap Emulation).
This ensures the user can mute and unmute videos as expected without affecting the volume settings.
Fixes: flutter/flutter#156444
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.