[webview]: Bump androidx.webkit:webkit from 1.12.0 to 1.12.1 in /packages/webview_flutter/webview_flutter_android/android

[dependabot]

Bumps androidx.webkit:webkit from 1.12.0 to 1.12.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[bparrishMines]

It looks like this bump requires bumping the minSdkVersion to 21 from 19:

> Task :webview_flutter_android:processDebugUnitTestManifest FAILED
/b/s/w/ir/x/w/packages/packages/webview_flutter/webview_flutter_android/example/build/webview_flutter_android/intermediates/tmp/manifest/test/debug/tempFile1ProcessTestManifest10711653206886110711.xml:5:5-74 Error:
	uses-sdk:minSdkVersion 19 cannot be smaller than version 21 declared in library [androidx.webkit:webkit:1.12.1] /b/s/w/ir/cache/gradle/caches/transforms-4/c14bd4619ceadf98b47fad0696ac6910/transformed/webkit-1.12.1/AndroidManifest.xml as the library might be using APIs not available in 19
	Suggestion: use a compatible library with a minSdk of at most 19,
		or increase this project's minSdk version to at least 21,
		or use tools:overrideLibrary="androidx.webkit" to force usage (may lead to runtime failures)

This is just a minor version bump for webkit and doesn't seem to have any major changes to it: https://developer.android.com/jetpack/androidx/releases/webkit#1.12.1.

@flutter/android-reviewers Do you have any objections to bumping this plugin to minSdkVersion of 21?

[gmackall]

@flutter/android-reviewers Do you have any objections to bumping this plugin to minSdkVersion of 21?

I think flutter only supports 21+ at this point
https://docs.flutter.dev/reference/supported-platforms
so I have no objection (though that page isn't versioned - I think that is true on the current stable, but I'd have to line up changes to the docs w/ the release calendar to know for sure).

[reidbaker]

No objections.

[bparrishMines]

LGTM

[stuartmorgan]

I thought we were going to do this as a minor version because this isn't actually breaking, since Flutter 3.24 requires 21+, so nobody should be able to be broken by this.

[bparrishMines]

Ah I thought that only applied to webview_flutter. And we would make this a breaking change for the plugin.

[bparrishMines]

Sorry I should have gotten an additional review for clarification. Will this bump cause conflicts and do we need to revert the publish?

[stuartmorgan]

It's going to make things unnecessarily difficult for anyone doing https://pub.dev/packages/webview_flutter#platform-specific-features because they will get resolver errors the next time they try to update webview_flutter, and will have to figure out they need to update their webview_flutter_android major version.

Withdrawing the published version would create a problem for us later when we actually want to bump the major version again, so I think we'll just have to live with the added friction for people with dependencies on the platform version.

[bparrishMines]

Ah ok now I understand. I forgot that the platform dependencies are explicitly used for platform specific features. Could we change the depdendency in webview_flutter to >=3.16.0 <5.0.0 temporarily? Or are we better off just setting it to ^4.0.0 with the friction.

[stuartmorgan]

That would just kick the can down the road very slightly, because the next time any feature is added we'll have to update the minimum endorsed versions to pick up the feature. Better to just get it out of the way now, rather than make the next feature update slightly more complex.