Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[path_provider] Update Android Pigeon for non-nullable generics #7783

Merged

Conversation

stuartmorgan
Copy link
Contributor

Removes workarounds for previous lack of non-nullable generics support. There are no native code changes because in practice we already didn't want nullable values in the collection, we just couldn't express it formally.

Part of flutter/flutter#155891

Pre-launch Checklist

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 7, 2024
@auto-submit auto-submit bot merged commit e784c3e into flutter:main Oct 7, 2024
76 checks passed
@stuartmorgan stuartmorgan deleted the pigeon-non-null-path-provider-android branch October 7, 2024 15:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 7, 2024
flutter/packages@05bf1d4...bb00d34

2024-10-07 [email protected] [google_sign_in] Update Pigeon for non-nullable generics (flutter/packages#7785)
2024-10-07 [email protected] [path_provider] Update Android Pigeon for non-nullable generics  (flutter/packages#7783)
2024-10-07 [email protected] [rfw] Increase tolerance for material widget tests (flutter/packages#7148)
2024-10-05 [email protected] [various] Update Java compatibility version to 11 (flutter/packages#7795)
2024-10-04 [email protected] [video_player] Update Pigeon for non-nullable generics (flutter/packages#7790)
2024-10-04 [email protected] [go_router] Added missing implementation for the routerNeglect parameter in GoRouter (flutter/packages#7752)
2024-10-04 [email protected] [google_maps_flutter_platform_interface] Convert `BitmapDescriptor` to typesafe subclasses (flutter/packages#7699)
2024-10-04 [email protected] [google_maps_flutter_platform_interface] Convert `PatternItem` and `Cap` to typesafe structures. (flutter/packages#7703)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: path_provider platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants