Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test iOS and macOS on Xcode 16 beta 1 #6942

Closed
wants to merge 2 commits into from
Closed

Test iOS and macOS on Xcode 16 beta 1 #6942

wants to merge 2 commits into from

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 17, 2024 •
edited
Loading

@jmagman jmagman changed the title iOS and macOS tests running on Xcode 16 Tesst iOS and macOS on Xcode 16 beta 1 Jun 17, 2024
@jmagman jmagman changed the title Tesst iOS and macOS on Xcode 16 beta 1 Test iOS and macOS on Xcode 16 beta 1 Jun 17, 2024
@jmagman jmagman mentioned this pull request Jun 18, 2024
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Jun 18, 2024
@jmagman
[pigeon] Fully-qualify types in Equatable extension test (#6946)
cd73061 
Updating to Xcode 16 exposed a new compilation error: "extension declares a conformance of imported type 'DataWithEnum' to imported protocol 'Equatable'".  The [Swift Warning for Retroactive Conformances of External Types](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0364-retroactive-conformance-warning.md) proposal says:

> It does mean projects building with an older Swift will not have access to [the @retroactive] syntax, so as a source compatible fallback, a client can silence this warning by fully-qualifying all types in the extension. As an example, the above conformance can also be written as
> ```
> extension Foundation.Date: Swift.Identifiable {
>     // ...
> }
> ```
> This will allow projects that need to build with multiple versions of Swift, and which have valid reason to declare such conformances, to declare them without tying their project to a newer compiler build.

So change the test to fully-qualify the types.  This prevented the warning when I tried it in #6942.

Fixes flutter/flutter#150391
@jmagman jmagman closed this Jun 21, 2024
@jmagman jmagman deleted the xcode-16 branch June 21, 2024 23:23
@jmagman jmagman restored the xcode-16 branch July 9, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin will be requested when the pull request is marked ready for review hellohuanlin is a code owner

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu LouiseHsu will be requested when the pull request is marked ready for review LouiseHsu is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal will be requested when the pull request is marked ready for review tarrinneal is a code owner

Assignees
No one assigned
Labels
p: pigeon platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmagman