-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[image_picker] Add missing entitlements to macOS example #4931
[image_picker] Add missing entitlements to macOS example #4931
Conversation
When endorsing macOS and adding the example app, I forgot to add the required entitlement, so the example didn't work. Fixes flutter/flutter#134817
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This currently can't be tested due to flutter/flutter#70234 Once that's implemented and we can do the UI testing backfill for this plugin, this will automatically be covered. |
No changelog: This only affects running locally, and is doing what the README already says to do. |
test-exempt: will be automatically covered once necessary test infrastructure lands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TAMNTM
Re-running |
flutter/packages@bc8c2f2...d4e2454 2023-09-18 [email protected] [camera_android] Removes usage of `_ambiguate` method in example (flutter/packages#4924) 2023-09-17 [email protected] Roll Flutter from e5e36ad to 1b18b13 (8 revisions) (flutter/packages#4940) 2023-09-16 [email protected] Roll Flutter from 72b69f9 to e5e36ad (12 revisions) (flutter/packages#4938) 2023-09-15 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.5.0 to 1.7.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#4891) 2023-09-15 [email protected] Roll Flutter from 58ba6c2 to 72b69f9 (21 revisions) (flutter/packages#4934) 2023-09-15 [email protected] [image_picker] Add missing entitlements to macOS example (flutter/packages#4931) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@bc8c2f2...d4e2454 2023-09-18 [email protected] [camera_android] Removes usage of `_ambiguate` method in example (flutter/packages#4924) 2023-09-17 [email protected] Roll Flutter from e5e36ad to 1b18b13 (8 revisions) (flutter/packages#4940) 2023-09-16 [email protected] Roll Flutter from 72b69f9 to e5e36ad (12 revisions) (flutter/packages#4938) 2023-09-15 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.5.0 to 1.7.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#4891) 2023-09-15 [email protected] Roll Flutter from 58ba6c2 to 72b69f9 (21 revisions) (flutter/packages#4934) 2023-09-15 [email protected] [image_picker] Add missing entitlements to macOS example (flutter/packages#4931) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
When endorsing macOS and adding the example app, I forgot to add the required entitlement, so the example didn't work. The actual fix is the entitlements file; the Runner.xc* changes are auto-generated by running `flutter build macos`; usually we do that before landing examples but clearly I didn't remember to actually run the example when endorsing in this case... Fixes flutter/flutter#134817
When endorsing macOS and adding the example app, I forgot to add the required entitlement, so the example didn't work.
The actual fix is the entitlements file; the Runner.xc* changes are auto-generated by running
flutter build macos
; usually we do that before landing examples but clearly I didn't remember to actually run the example when endorsing in this case...Fixes flutter/flutter#134817
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).