Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] Adds unnecessary_import to linter ignore list for package:flutter/foundation.dart #2290

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jun 29, 2022

Fixes failure in #2285. This keeps the foundation import because I assume it will be needed on lower versions of Flutter.

No tests since it's fixing analyze test.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines merged commit 9560fe7 into flutter:main Jun 29, 2022
@bparrishMines bparrishMines deleted the imports branch June 29, 2022 18:50
@bparrishMines bparrishMines changed the title [pigeon] Adds unnecessary_import to linter ignore list for package:flutter/foundation.dart [pigeon] Adds unnecessary_import to linter ignore list in generated dart tests Jun 29, 2022
@bparrishMines bparrishMines changed the title [pigeon] Adds unnecessary_import to linter ignore list in generated dart tests [pigeon] Adds unnecessary_import to linter ignore list for package:flutter/foundation.dart Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants