Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide monitor information. #161359

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Provide monitor information. #161359

merged 1 commit into from
Jan 12, 2025

Conversation

robert-ancell
Copy link
Contributor

Fixes #144230

@robert-ancell robert-ancell requested a review from mattkae January 9, 2025 03:48
@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Jan 9, 2025
loic-sharma
loic-sharma approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robert-ancell robert-ancell added this pull request to the merge queue Jan 12, 2025
Merged via the queue into flutter:master with commit d14140f Jan 12, 2025
177 checks passed
@robert-ancell robert-ancell deleted the linux-notify-displays branch January 12, 2025 22:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 13, 2025
@engine-flutter-autoroll
d14140f85 Provide monitor information. (flutter/flutter#161359)
b2ab565
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 13, 2025
@engine-flutter-autoroll
d14140f85 Provide monitor information. (flutter/flutter#161359)
b2594bd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 13, 2025
@engine-flutter-autoroll
d14140f85 Provide monitor information. (flutter/flutter#161359)
5491bc4
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 13, 2025
@engine-flutter-autoroll
Roll Flutter from 864d4f59dde0 to 72db8f69e339 (11 revisions) (#8421)
d682dcf 
flutter/flutter@864d4f5...72db8f6

2025-01-13 [email protected] Roll Packages from 6554751 to 3c3bc68 (16 revisions) (flutter/flutter#161515)
2025-01-13 [email protected] Update error message for when leading/trailing width exceeds `ListTile` width and add missing test (flutter/flutter#161091)
2025-01-13 [email protected] Deprecate unused `ButtonStyleButton.iconAlignment` property (flutter/flutter#160023)
2025-01-12 [email protected] Provide monitor information. (flutter/flutter#161359)
2025-01-11 [email protected] [android_engine_test] Remove background/foreground from surface texture trampoline test. (flutter/flutter#161441)
2025-01-11 [email protected] Remove some miscellaneous references to Cirrus. (flutter/flutter#161390)
2025-01-11 [email protected] add semantics role and tab (flutter/flutter#161260)
2025-01-10 [email protected] CupertinoSheetRoute (flutter/flutter#157568)
2025-01-10 [email protected] Update `TextEditingController.text` documentation to recommend against using it in production code (flutter/flutter#157769)
2025-01-10 [email protected] ð��� [tool] Add a wirelessly connected device name as `displayName` (flutter/flutter#160497)
2025-01-10 [email protected] FixForward: method was renamed (flutter/flutter#161431)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
maheshj01 pushed a commit to maheshj01/flutter that referenced this pull request Jan 15, 2025
@robert-ancell @maheshj01
Provide monitor information. (flutter#161359)
afa6b41 
Fixes flutter#144230
@loic-sharma
Copy link
Member

@robert-ancell Hey, I realized after the fact that we should update this doc:

flutter/engine/src/flutter/lib/ui/platform_dispatcher.dart

Lines 175 to 179 in 1580a3d

/// Presently, on Android and Web this collection will only contain the
/// display that the current window is on. On iOS, it will only contains the
/// main display on the phone or tablet. On Desktop, it will contain only
/// a main display with a valid refresh rate but invalid size and device
/// pixel ratio values.

@robert-ancell robert-ancell mentioned this pull request Jan 17, 2025
Open
robert-ancell added a commit to robert-ancell/flutter that referenced this pull request Jan 17, 2025
@robert-ancell
Update documentation on what display information is provided.
9fc3672 
This was fixed in Linux in flutter#161359
@robert-ancell robert-ancell mentioned this pull request Jan 17, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 19, 2025
@robert-ancell
Update documentation on what display information is provided. (#161785)
6311057 
This was fixed in Linux in
#161359
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
d14140f85 Provide monitor information. (flutter/flutter#161359)
c772e56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
d14140f85 Provide monitor information. (flutter/flutter#161359)
bf7522f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
d14140f85 Provide monitor information. (flutter/flutter#161359)
c9e202c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
d14140f85 Provide monitor information. (flutter/flutter#161359)
80e305d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
d14140f85 Provide monitor information. (flutter/flutter#161359)
1ce5fee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@mattkae mattkae Awaiting requested review from mattkae

@cbracken cbracken Awaiting requested review from cbracken

Assignees
No one assigned
Labels
a: desktop Running on desktop engine flutter/engine repository. See also e: labels. platform-linux Building on or for Linux specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot retrieve display size on Linux
2 participants
@robert-ancell @loic-sharma