Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid labeling all PRs as 'text-input' #157805

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 29, 2024

After #157650 all PRs are being labeled as text-input by the PR labeler. I think the config is missing an all based on the negation example

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Oct 29, 2024
@jmagman jmagman self-assigned this Oct 29, 2024
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems and removed team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Oct 29, 2024
@jmagman jmagman removed the a: text input Entering text in a text field or keyboard related problems label Oct 29, 2024
@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Oct 29, 2024
@jmagman
Copy link
Member Author

jmagman commented Oct 29, 2024

Closing, I give up, I'll revert #157650 instead.

@jmagman jmagman closed this Oct 29, 2024
@jmagman jmagman deleted the text-input-label branch October 29, 2024 17:21
@jmagman jmagman restored the text-input-label branch October 29, 2024 17:23
@jmagman
Copy link
Member Author

jmagman commented Oct 29, 2024

Oh wait, the labeler was using the one on main, not this PR https://github.com/flutter/flutter/actions/runs/11579120557/job/32234576590#step:2:91

Maybe this did work...

@jmagman jmagman reopened this Oct 29, 2024
@github-actions github-actions bot removed the a: text input Entering text in a text field or keyboard related problems label Oct 29, 2024
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Without understanding how it works tho)

@jmagman
Copy link
Member Author

jmagman commented Oct 29, 2024

LGTM! (Without understanding how it works tho)

I promise to revert this for good if it goes haywire again.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2024
@auto-submit auto-submit bot merged commit 7c27a05 into flutter:master Oct 29, 2024
33 checks passed
@jmagman jmagman deleted the text-input-label branch October 30, 2024 03:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 30, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 30, 2024
flutter/flutter@42132e8...fe71cad

2024-10-30 [email protected] Update CHANGELOG.md to correct ios vs macos issue (flutter/flutter#157822)
2024-10-30 [email protected] Add ability to customize the default `Slider` padding (flutter/flutter#156143)
2024-10-30 [email protected] Fix menu anchor state handling (flutter/flutter#157612)
2024-10-30 [email protected] Add test for `interactive_viewer.0.dart` (flutter/flutter#157773)
2024-10-30 [email protected] Add test for `scroll_metrics_notification.0.dart` (flutter/flutter#157768)
2024-10-30 [email protected] Add boundary feature to the drag gesture. (flutter/flutter#147521)
2024-10-30 [email protected] Fix `ResizeImage` documentation (flutter/flutter#157619)
2024-10-29 [email protected] Roll Flutter Engine from 795b5492f1b9 to 999797a2f690 (1 revision) (flutter/flutter#157825)
2024-10-29 [email protected] Avoid labeling all PRs as 'text-input' (flutter/flutter#157805)
2024-10-29 [email protected] Roll Packages from e0c4f55 to 028027e (8 revisions) (flutter/flutter#157813)
2024-10-29 [email protected] Roll Flutter Engine from 725c8e4bc379 to 795b5492f1b9 (5 revisions) (flutter/flutter#157820)
2024-10-29 [email protected] Fix and remove a few `no-shuffle` tags in `flutter_tools`. (flutter/flutter#157656)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants