Wide gamut framework gradient test #153976

gaaclarke · 2024-08-22T22:50:34Z

issue: #127855
depends on flutter/engine#54748 being rolled into the framework

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This implements wide gamut color support for gradients in the engine. issue: flutter/flutter#127855 integration test: flutter/flutter#153976 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

gaaclarke · 2024-09-05T00:23:06Z

I'm putting this into review, it shouldn't land until flutter/engine#54748 rolls into the framework though.

jonahwilliams

LGTM

auto-submit · 2024-09-05T04:09:25Z

auto label is removed for flutter/flutter/153976, due to - The status or check suite Windows tool_integration_tests_2_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

jonahwilliams · 2024-10-25T17:36:40Z

reason for revert: failing on postsubmit

jonahwilliams · 2024-10-25T17:37:01Z

See: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20wide_gamut_ios/9920/overview

This reverts commit 4f66f13.

Reverts: #153976 Initiated by: jonahwilliams Reason for reverting: failing on postsubmit Original PR Author: gaaclarke Reviewed By: {jonahwilliams} This change reverts the following previous change: issue: #127855 depends on flutter/engine#54748 being rolled into the framework

gaaclarke · 2024-10-25T17:57:44Z

things got broke in the engine after this PR didn't land because of a flake that blocked the autosubmit =(

gaaclarke · 2024-10-25T18:15:39Z

I ran these locally against 57c4bd0 and they still didn't pass. Something happened between testing them locally and getting them landed in the separate repo.

jonahwilliams · 2024-10-25T18:17:32Z

Lets make sure we don't need to cherry pick anything to get wide gamut working...

gaaclarke · 2024-10-25T18:29:00Z

Lets make sure we don't need to cherry pick anything to get wide gamut working...

Looking into it. FWIW the standard wide gamut tests are passing, this is just for gradients.

gaaclarke · 2024-10-25T20:41:28Z

I verified that the colors are wide gamut all the way to sending them to the buffer. On the output side the closest color to p3 red is (0.9965759667968751 -0.0014706249999999477 -0.0014706249999999477). I was wondering if the blending of colors was making looking for p3 red fail by being slightly off but it seems like there may be some clamping done in the fragment shader.

gaaclarke · 2024-10-25T21:25:34Z

Found the clamping, it's in the dithering: https://github.com/flutter/engine/blob/7c5c5fe5c84dca784bf51d47840447411f547b03/impeller/compiler/shader_lib/impeller/dithering.glsl#L49

gaaclarke · 2024-10-25T21:28:34Z

We could fix the dithering math, but dithering actually isn't desirable either when we have wide gamut colors since we have 10bits per color component.

jonahwilliams · 2024-10-25T21:29:08Z

Wide gamut doesn't fix gradient banding. But we don't actually need to clamp there, so we can just delete it. For non wide gamut the driver will clamp

gaaclarke · 2024-10-25T21:33:48Z

Wide gamut doesn't fix gradient banding.

It does in our case, banding with 10bits per color component is beyond the perceptible limit.

But we don't actually need to clamp there, so we can just delete it.

Yea, playing with it.

…flutter#157615)" This reverts commit add7e81.

gaaclarke · 2024-10-25T21:54:02Z

Removing the dithering works for the linear and the sweep gradient. For the conical and the radial gradient it looks like you aren't guaranteed to get your requested color back so tweaking the threshold for those tests will be necessary.

jonahwilliams · 2024-10-25T21:55:54Z

I think if you want the test to be stable you need to either use an epsilon or make it a single color gradient

tests: flutter/flutter#157643 fixes revert from flutter/flutter#153976 The pixel format will clamp if it needs to anyway so this isn't necessary. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

This was reverted because it failed to run. Colors were getting clamped in the dithering fragment shader. One change was made when relanding, i increased the epsilon for the radial and conical gradients. They don't appear to give back the exact color you asked for. Do not land until flutter/engine#56140 is rolled into the framework. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Roll Flutter from 4faa4a415ec9 to 5a11904383d1 (67 revisions) flutter/flutter@4faa4a4...5a11904 2024-10-26 [email protected] Relands "Wide gamut framework gradient test (#153976)" (flutter/flutter#157643) 2024-10-26 [email protected] Roll Flutter Engine from 7c5c5fe5c84d to c9b8ac96f6ce (3 revisions) (flutter/flutter#157662) 2024-10-26 [email protected] Add test for `navigator_state.restorable_push_and_remove_until.0.dart` (flutter/flutter#157595) 2024-10-26 [email protected] Tighten up `throwToolExit`, explain when to use it. (flutter/flutter#157561) 2024-10-26 [email protected] Remove extraneous `throw`. (flutter/flutter#157658) 2024-10-26 [email protected] Add tests for `navigator.restorable_push.0.dart` (flutter/flutter#157492) 2024-10-25 [email protected] Roll Flutter Engine from 43e4d9a30666 to 7c5c5fe5c84d (1 revision) (flutter/flutter#157644) 2024-10-25 [email protected] Roll Flutter Engine from 5061358e255f to 43e4d9a30666 (1 revision) (flutter/flutter#157637) 2024-10-25 [email protected] Roll Flutter Engine from eb867e055790 to 5061358e255f (2 revisions) (flutter/flutter#157623) 2024-10-25 [email protected] Create flutter specific leak troubleshooting guidance. (flutter/flutter#157396) 2024-10-25 [email protected] Update CupertinoNavigationBar to support large layout (flutter/flutter#157133) 2024-10-25 [email protected] Roll Flutter Engine from 38e9be1f74fa to eb867e055790 (3 revisions) (flutter/flutter#157613) 2024-10-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Wide gamut framework gradient test (#153976)" (flutter/flutter#157615) 2024-10-25 [email protected] Wide gamut framework gradient test (flutter/flutter#153976) 2024-10-25 [email protected] Roll Flutter Engine from b413d9996c86 to 38e9be1f74fa (2 revisions) (flutter/flutter#157604) 2024-10-25 [email protected] Roll Packages from a556f0f to e0c4f55 (2 revisions) (flutter/flutter#157605) 2024-10-25 [email protected] Support backdrop key in flutter framework. (flutter/flutter#157278) 2024-10-25 [email protected] Add 3.24.4 changelog to master (flutter/flutter#157600) 2024-10-25 [email protected] Update flutter.groovy to catch unknown task exception when finding api task (flutter/flutter#157282) 2024-10-25 [email protected] Roll Flutter Engine from c4b0184c8783 to b413d9996c86 (1 revision) (flutter/flutter#157580) 2024-10-25 [email protected] Roll Flutter Engine from b1c2ba8c4d52 to c4b0184c8783 (1 revision) (flutter/flutter#157578) 2024-10-25 [email protected] Add test for `build_owner.0.dart` (flutter/flutter#157499) 2024-10-25 [email protected] Add tests for `focusable_action_detector.0.dart` (flutter/flutter#157575) 2024-10-25 [email protected] Add test for `navigator.restorable_push_and_remove_until.0.dart` (flutter/flutter#157487) 2024-10-25 [email protected] Roll Flutter Engine from 29440ed1e225 to b1c2ba8c4d52 (1 revision) (flutter/flutter#157572) 2024-10-25 [email protected] Roll Flutter Engine from 88716d804aef to 29440ed1e225 (1 revision) (flutter/flutter#157569) 2024-10-25 [email protected] Roll Flutter Engine from b8b28c80a737 to 88716d804aef (2 revisions) (flutter/flutter#157567) 2024-10-24 [email protected] Roll Flutter Engine from 48ff670d256b to b8b28c80a737 (2 revisions) (flutter/flutter#157564) 2024-10-24 [email protected] Use discenrable characters (replace `' ð�� ð�� '` in error logs) (flutter/flutter#157548) 2024-10-24 [email protected] Remove unused `PubDependenciesProjectValidator`. (flutter/flutter#157516) 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (#157032)" (flutter/flutter#157559) 2024-10-24 [email protected] Mark mac impeller as bringup. (flutter/flutter#157551) 2024-10-24 [email protected] Deprecate `ThemeData.dialogBackgroundColor` in favor of `DialogThemeData.backgroundColor` (flutter/flutter#155072) 2024-10-24 [email protected] Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter/flutter#157032) 2024-10-24 [email protected] Roll Flutter Engine from 246344f26edc to 48ff670d256b (2 revisions) (flutter/flutter#157544) 2024-10-24 [email protected] Allow opting out of `.flutter-plugins`, opt-out in `refreshPluginsList`. (flutter/flutter#157527) 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (#157388)" (#157541)" (flutter/flutter#157549) 2024-10-24 [email protected] Changes the offset computation to first item for RenderSliverMainAxisGroup (flutter/flutter#154688) 2024-10-24 [email protected] Roll Packages from 5e03bb1 to a556f0f (7 revisions) (flutter/flutter#157539) 2024-10-24 [email protected] Add partial test for flutter build ios-framework on non-module (flutter/flutter#157482) 2024-10-24 [email protected] Add example to SafeArea docs (flutter/flutter#157228) 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (#157388)" (flutter/flutter#157541) 2024-10-24 [email protected] Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (flutter/flutter#157388) 2024-10-24 [email protected] Roll Flutter Engine from be56084344d1 to 246344f26edc (2 revisions) (flutter/flutter#157504) 2024-10-24 [email protected] Add ability to disable CupertinoSegmentedControl (flutter/flutter#152813) 2024-10-24 [email protected] Update `Tab.height` parameter doc for tab height lower than default (flutter/flutter#157443) ...

tests: flutter/flutter#157643 fixes revert from flutter/flutter#153976 The pixel format will clamp if it needs to anyway so this isn't necessary. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

tests: flutter#157643 fixes revert from flutter#153976 The pixel format will clamp if it needs to anyway so this isn't necessary. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

This was referenced Aug 23, 2024

Framework wide color linear gradients flutter/engine#54748

Merged

[ui] fix missing color conversion in drawAtlas. flutter/engine#54750

Merged

gaaclarke force-pushed the wide-gamut-framework-gradient-test branch from 38d8fad to 35d63b1 Compare September 5, 2024 00:19

gaaclarke marked this pull request as ready for review September 5, 2024 00:21

gaaclarke requested review from matanlurey and jonahwilliams September 5, 2024 00:22

jonahwilliams approved these changes Sep 5, 2024

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2024

gaaclarke added 5 commits October 25, 2024 09:14

Adds wide gamut gradient test

6b7a97b

added radial gradient

3eedc76

added conical test

a4efac0

added sweep test

37ec128

lints

9eaf9b5

gaaclarke force-pushed the wide-gamut-framework-gradient-test branch from 6f64c08 to 9eaf9b5 Compare October 25, 2024 16:14

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 25, 2024

auto-submit bot merged commit 4f66f13 into flutter:master Oct 25, 2024
148 checks passed

jonahwilliams added the revert Autorevert PR (with "Reason for revert:" comment) label Oct 25, 2024

auto-submit bot pushed a commit that referenced this pull request Oct 25, 2024

Revert "Wide gamut framework gradient test (#153976)"

6544a55

This reverts commit 4f66f13.

auto-submit bot mentioned this pull request Oct 25, 2024

Reverts "Wide gamut framework gradient test (#153976)" #157615

Merged

9 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Oct 25, 2024

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to add7e81f4f5c (55 revisions) flutter/packages#7933

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

4f66f1333 Wide gamut framework gradient test (flutter/flutter#153976)

77c7546

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to 6337eb1a3925 (56 revisions) flutter/packages#7934

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

4f66f1333 Wide gamut framework gradient test (flutter/flutter#153976)

37ba020

gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Oct 25, 2024

Revert "Reverts "Wide gamut framework gradient test (flutter#153976)" (…

89bc6e4

…flutter#157615)" This reverts commit add7e81.

gaaclarke mentioned this pull request Oct 25, 2024

Removed clamping from dithering flutter/engine#56140

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Oct 26, 2024

Roll Flutter from 4faa4a415ec9 to 9327c24d8086 (66 revisions) flutter/packages#7936

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2024

4f66f1333 Wide gamut framework gradient test (flutter/flutter#153976)

9f33060

engine-flutter-autoroll mentioned this pull request Oct 26, 2024

Roll Flutter from 4faa4a415ec9 to 5a11904383d1 (67 revisions) flutter/packages#7937

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2024

4f66f1333 Wide gamut framework gradient test (flutter/flutter#153976)

ce8152c

gaaclarke mentioned this pull request Oct 28, 2024

[cp] Removed clamping from dithering (#56140) flutter/engine#56174

Merged

16 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

4f66f1333 Wide gamut framework gradient test (flutter/flutter#153976)

e998407

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

4f66f1333 Wide gamut framework gradient test (flutter/flutter#153976)

dda4a69

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

4f66f1333 Wide gamut framework gradient test (flutter/flutter#153976)

bb38b38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wide gamut framework gradient test #153976

Wide gamut framework gradient test #153976

gaaclarke commented Aug 22, 2024 •

edited

Loading

gaaclarke commented Sep 5, 2024

jonahwilliams left a comment

auto-submit bot commented Sep 5, 2024

jonahwilliams commented Oct 25, 2024

jonahwilliams commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

jonahwilliams commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

jonahwilliams commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

jonahwilliams commented Oct 25, 2024

Wide gamut framework gradient test #153976

Wide gamut framework gradient test #153976

Conversation

gaaclarke commented Aug 22, 2024 • edited Loading

Pre-launch Checklist

gaaclarke commented Sep 5, 2024

jonahwilliams left a comment

Choose a reason for hiding this comment

auto-submit bot commented Sep 5, 2024

jonahwilliams commented Oct 25, 2024

jonahwilliams commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

jonahwilliams commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

jonahwilliams commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

gaaclarke commented Oct 25, 2024

jonahwilliams commented Oct 25, 2024

gaaclarke commented Aug 22, 2024 •

edited

Loading