Switch imports from test_api to focused libaries #125854
Conversation
Move imports of API available in `hooks.dart` or `scaffolding.dart` to use those more narrow libraries. Move imports of APIs from `package:matcher` to import directly. The next major version of `test_api` will remove the exports of `matcher` APIs.
flutter-dashboard
bot
added
a: tests
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
natebosch
added
the
autosubmit
|
test-exempt: preparing for roll |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 125854, due to - The status or check suite Windows customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
I don't understand the failure on "Windows customer_testing" - it looks like it may be some infrastructure failure? |
customer_testing compares the registry against the branch point from master. If this was fixed upstream you'd need to rebase (not merge) upstream master to pick up the fix. |
If it fails again I will try a rebase. Is there any discussion of fixing this so it isn't a requirement to rewrite shared history? |
not sure. |
natebosch
added
the
autosubmit
|
It passed this time, so it may have been a flake. |
|
I'm not sure whether "Google testing" is still doing any work, it says "Presubmit Test Passed"... |
|
There's a bug that sometimes Frob doesn't sync back a successful test run. I manually set it to green. |
Move imports of API available in
hooks.dartorscaffolding.dartto use those more narrow libraries.Move imports of APIs from
package:matcherto import directly. The next major version oftest_apiwill remove the exports ofmatcherAPIs.