Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Mac_arm64 tool_host_cross_arch_tests not flaky #118484

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Mark Mac_arm64 tool_host_cross_arch_tests not flaky #118484

merged 1 commit into from
Jan 13, 2023

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jan 13, 2023

#112130 has been fixed, move Mac_arm64 test from staging to prod.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Jan 13, 2023
@jmagman jmagman requested a review from keyonghan as a code owner January 13, 2023 21:48
@jmagman jmagman requested a review from godofredoc January 13, 2023 21:49
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2023
@auto-submit auto-submit bot merged commit 68dd63d into flutter:master Jan 13, 2023
@jmagman jmagman deleted the tool_host_cross_arch_tests-flaky branch January 13, 2023 23:41
@jmagman
Copy link
Member Author

jmagman commented Jan 13, 2023

It hasn't recipe crashed! https://ci.chromium.org/p/flutter/builders/prod/Mac_arm64%20tool_host_cross_arch_tests/7

@godofredoc
Copy link
Contributor

It hasn't recipe crashed! https://ci.chromium.org/p/flutter/builders/prod/Mac_arm64%20tool_host_cross_arch_tests/7

Nice, just in time, @yusuf-goog just confirmed we got a few more M1 machines

@jmagman
Copy link
Member Author

jmagman commented Jan 14, 2023

Nice, just in time, @yusuf-goog just confirmed we got a few more M1 machines

Good, maybe I can revisit #109889 then, which was reverted.

This was referenced Jan 14, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2023
@engine-flutter-autoroll
68dd63d Mark Mac_arm64 tool_host_cross_arch_tests not flaky (flutter/…
af6668d 
…flutter#118484)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 14, 2023
@engine-flutter-autoroll
68dd63d Mark Mac_arm64 tool_host_cross_arch_tests not flaky (flutter/…
ed2fb59 
…flutter#118484)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 14, 2023
@engine-flutter-autoroll
Roll Flutter from 2201698 to 68dd63d (9 revisions) (#3047)
3da5f81 
* 8900bda a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter/flutter#118454)

* fb1a151 Roll Plugins from 39197f1 to 92a5367 (4 revisions) (flutter/flutter#118457)

* 3a181e4 Added LinearBorder, an OutlinedBorder like BoxBorder (flutter/flutter#116940)

* a523f79 Marks Mac_ios spell_check_test to be unflaky (flutter/flutter#117743)

* cea55d9 [Linux] Add a 'flutter run' console output test (flutter/flutter#118279)

* b4d7275 Add Info.plist from build directory as input path to Thin Binary build phase (flutter/flutter#118209)

* 2fd8250 [flutter_tools] re-enable web shader compilation (flutter/flutter#118461)

* 13a8dce Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter/flutter#118482)

* 68dd63d Mark Mac_arm64 tool_host_cross_arch_tests not flaky (flutter/flutter#118484)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Jan 14, 2023
@engine-flutter-autoroll
Roll Flutter from 2201698 to 68dd63d (9 revisions) (#6956)
1efd518 
* 8900bda a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter/flutter#118454)

* fb1a151 Roll Plugins from 39197f1 to 92a5367 (4 revisions) (flutter/flutter#118457)

* 3a181e4 Added LinearBorder, an OutlinedBorder like BoxBorder (flutter/flutter#116940)

* a523f79 Marks Mac_ios spell_check_test to be unflaky (flutter/flutter#117743)

* cea55d9 [Linux] Add a 'flutter run' console output test (flutter/flutter#118279)

* b4d7275 Add Info.plist from build directory as input path to Thin Binary build phase (flutter/flutter#118209)

* 2fd8250 [flutter_tools] re-enable web shader compilation (flutter/flutter#118461)

* 13a8dce Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter/flutter#118482)

* 68dd63d Mark Mac_arm64 tool_host_cross_arch_tests not flaky (flutter/flutter#118484)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@jmagman @gspencergoog
Mark Mac_arm64 tool_host_cross_arch_tests not flaky (flutter#118484)
0345275
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 2201698 to 68dd63d (9 revisions) (flutter#6956)
8608912 
* 8900bda a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter/flutter#118454)

* fb1a151 Roll Plugins from 39197f1 to 92a5367 (4 revisions) (flutter/flutter#118457)

* 3a181e4 Added LinearBorder, an OutlinedBorder like BoxBorder (flutter/flutter#116940)

* a523f79 Marks Mac_ios spell_check_test to be unflaky (flutter/flutter#117743)

* cea55d9 [Linux] Add a 'flutter run' console output test (flutter/flutter#118279)

* b4d7275 Add Info.plist from build directory as input path to Thin Binary build phase (flutter/flutter#118209)

* 2fd8250 [flutter_tools] re-enable web shader compilation (flutter/flutter#118461)

* 13a8dce Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter/flutter#118482)

* 68dd63d Mark Mac_arm64 tool_host_cross_arch_tests not flaky (flutter/flutter#118484)
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
@engine-flutter-autoroll @Maatteogekko
Roll Flutter from 2201698 to 68dd63d (9 revisions) (flutter#3047)
ed612f2 
* 8900bda a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter/flutter#118454)

* fb1a151 Roll Plugins from 39197f1 to 92a5367 (4 revisions) (flutter/flutter#118457)

* 3a181e4 Added LinearBorder, an OutlinedBorder like BoxBorder (flutter/flutter#116940)

* a523f79 Marks Mac_ios spell_check_test to be unflaky (flutter/flutter#117743)

* cea55d9 [Linux] Add a 'flutter run' console output test (flutter/flutter#118279)

* b4d7275 Add Info.plist from build directory as input path to Thin Binary build phase (flutter/flutter#118209)

* 2fd8250 [flutter_tools] re-enable web shader compilation (flutter/flutter#118461)

* 13a8dce Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter/flutter#118482)

* 68dd63d Mark Mac_arm64 tool_host_cross_arch_tests not flaky (flutter/flutter#118484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godofredoc godofredoc godofredoc approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagman @godofredoc