Add ability for PrebuiltWindowsApp to accept a zip archive. #103918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
christopherfujino
approved these changes
May 16, 2022
| ); | ||
| } | ||
|
|
||
| if (!applicationBinary.existsSync()) { |
There was a problem hiding this comment.
Any reason not to check this before the check for .exe?
There was a problem hiding this comment.
I was following the original code logic, but I do think it makes sense to check it before. Updated, thanks!
| return null; | ||
| } | ||
|
|
||
| // Try to unpack as a zip. |
There was a problem hiding this comment.
Should this file end in .zip?
There was a problem hiding this comment.
Added the check, and updated test case for this.
| final Directory tempDir = globals.fs.systemTempDirectory.createTempSync('flutter_app.'); | ||
| try { | ||
| globals.os.unzip(globals.fs.file(applicationBinary), tempDir); | ||
| } on ProcessException { |
There was a problem hiding this comment.
I believe on Windows this uses package:archive, so i doubt this will throw a ProcessException. Looks like hte code throws ArchiveException
There was a problem hiding this comment.
Ah I didn't know that. Thanks for catching this!
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be used internally for supporting windows development workflow.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.