Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Dispose pictures created in HtmlViewEmbedder.submitFrame #57102

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

jason-simmons
Copy link
Member

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Dec 10, 2024
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great catch! Thanks for fixing it.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2024
@auto-submit auto-submit bot merged commit b59afdf into flutter:main Dec 11, 2024
31 checks passed
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 11, 2024
…160110)

flutter/engine@7941d78...3cdd841

2024-12-11 [email protected] [Impeller] set UniformBlockBinding
once. (flutter/engine#57094)
2024-12-11 [email protected] Roll Fuchsia Linux SDK from
5taAI9-tnFN84ZJvr... to HJ57Y3zxqDamI8qkY... (flutter/engine#57125)
2024-12-11 [email protected] Removed linear
gradient heap allocation for color conversions between dart and display
list (flutter/engine#57108)
2024-12-11 [email protected] Dispose pictures
created in HtmlViewEmbedder.submitFrame (flutter/engine#57102)
2024-12-11 [email protected] Roll Dart SDK from
4789a86f4d3f to be9c98daf9df (1 revision) (flutter/engine#57124)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 5taAI9-tnFN8 to HJ57Y3zxqDam

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants