This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Made it so angle builds on linux #56328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could potentially just wrap this up into the work to make the golden test runner run on linux. I wanted to make sure we didn't lose this because it's very stupid and it took me a long time to hunt down. |
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 4, 2024
…158132) flutter/engine@25c7e47...f880b56 2024-11-04 [email protected] Made it so angle builds on linux (flutter/engine#56328) 2024-11-04 [email protected] [Impeller] combine translate* scale mat mul when computing shader transform. (flutter/engine#56352) 2024-11-04 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.1 to 4.2.2 (flutter/engine#56191) 2024-11-04 [email protected] iOS: Eliminate fml::scoped_nsobject pointer use (flutter/engine#56295) 2024-11-04 [email protected] Roll Skia from e2ad60ea8039 to b2bb3af36da3 (1 revision) (flutter/engine#56355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
fixes: flutter#151353 Before this PR, angle would not build on linux, now it does. example: ``` ./flutter/bin/et build -c host_debug_unopt //flutter/third_party/angle:libGLESv2 ``` There isn't a CI step that builds this today to verify it keeps working, I implemented this as part of the work to see if i could get the golden test runner working on linux. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: flutter/flutter#151353
Before this PR, angle would not build on linux, now it does.
example:
There isn't a CI step that builds this today to verify it keeps working, I implemented this as part of the work to see if i could get the golden test runner working on linux.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.