Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Removed clamping from dithering #56140

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Removed clamping from dithering #56140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e254ec7
Removed clamping from dithering
gaaclarke Oct 25, 2024
24c24c0
updated malioc
gaaclarke Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions impeller/compiler/shader_lib/impeller/dithering.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ vec4 IPOrderedDither8x8(vec4 color, vec2 dest) {
// Apply the dither to the color.
color.rgb += dither * kDitherRate;

// Clamp the color values to [0,1].
color.rgb = clamp(color.rgb, 0.0, 1.0);

return color;
}

Expand Down
24 changes: 12 additions & 12 deletions impeller/tools/malioc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@
"shortest_path_cycles": [
0.5,
0.109375,
0.296875,
0.28125,
0.5,
0.0,
0.25,
Expand All @@ -596,9 +596,9 @@
"load_store"
],
"total_cycles": [
1.4249999523162842,
1.40625,
0.862500011920929,
1.4249999523162842,
1.40625,
0.875,
4.0,
0.25,
Expand Down Expand Up @@ -636,7 +636,7 @@
"longest_path_cycles": [
0.5,
0.109375,
0.125,
0.109375,
0.5,
0.0,
0.25,
Expand All @@ -658,7 +658,7 @@
"shortest_path_cycles": [
0.5,
0.109375,
0.125,
0.109375,
0.5,
0.0,
0.25,
Expand All @@ -671,7 +671,7 @@
"total_cycles": [
0.5,
0.109375,
0.125,
0.109375,
0.5,
0.0,
0.25,
Expand Down Expand Up @@ -6298,7 +6298,7 @@
"shortest_path_cycles": [
0.5625,
0.203125,
0.265625,
0.25,
0.5625,
0.0,
0.25,
Expand All @@ -6308,9 +6308,9 @@
"load_store"
],
"total_cycles": [
0.71875,
0.699999988079071,
0.40625,
0.71875,
0.699999988079071,
0.5625,
4.0,
0.25,
Expand Down Expand Up @@ -6768,7 +6768,7 @@
"shortest_path_cycles": [
0.5625,
0.21875,
0.28125,
0.265625,
0.5625,
0.0,
0.25,
Expand All @@ -6778,9 +6778,9 @@
"load_store"
],
"total_cycles": [
0.71875,
0.699999988079071,
0.421875,
0.71875,
0.699999988079071,
0.625,
4.0,
0.25,
Expand Down