Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the web compilation step to use an AOT snapshot #56040

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

a-siva
Copy link
Contributor

@a-siva a-siva commented Oct 23, 2024

Switch the Dart Development Compiler compilation step to use the dartdevc AOT snapshot.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Oct 23, 2024
@a-siva a-siva requested a review from yjbanov October 23, 2024 18:16
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@a-siva a-siva merged commit 838250e into flutter:main Oct 23, 2024
27 checks passed
@a-siva a-siva deleted the ddc-snapshot branch October 23, 2024 20:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 24, 2024
…157478)

flutter/engine@73c54fa...5d7caf7

2024-10-23 [email protected] Delete v1 android engine embedding (flutter/engine#52022)
2024-10-23 [email protected] [ios][platform_view]force reset forwarding recognizer state when its stuck (flutter/engine#55958)
2024-10-23 [email protected] Allow running the YAPF formatter using Python version 3.11 (flutter/engine#56062)
2024-10-23 [email protected] [Impeller] optimize clip rects by checking if integral coverage is sufficient. (flutter/engine#56041)
2024-10-23 [email protected] Switch the web compilation step to use an AOT snapshot (flutter/engine#56040)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
M97Chahboun pushed a commit to M97Chahboun/flutter that referenced this pull request Oct 30, 2024
…lutter#157478)

flutter/engine@73c54fa...5d7caf7

2024-10-23 [email protected] Delete v1 android engine embedding (flutter/engine#52022)
2024-10-23 [email protected] [ios][platform_view]force reset forwarding recognizer state when its stuck (flutter/engine#55958)
2024-10-23 [email protected] Allow running the YAPF formatter using Python version 3.11 (flutter/engine#56062)
2024-10-23 [email protected] [Impeller] optimize clip rects by checking if integral coverage is sufficient. (flutter/engine#56041)
2024-10-23 [email protected] Switch the web compilation step to use an AOT snapshot (flutter/engine#56040)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…e#56040)

Switch the Dart Development Compiler compilation step to use the
dartdevc AOT snapshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants