Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Add more package:test (removing usages of package:litetest) #54882

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Aug 29, 2024

... also removed a few TODOs, deleted a proof of concept directory.

Work towards flutter/flutter#133569.

@matanlurey matanlurey requested a review from jtmcdole August 29, 2024 22:52
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke
Copy link
Member

I didn't see this PR and started migrating one package myself. I think you are running into the same problem I ran into here: #54909

When invoking litetest it looks like we didn't have asserts turned on so tests would expect that we'd get a StateError, but instead we'd get an assertion error when executing with dart test. I solved it by removing the assertion in the skia gold client since the StateError is thrown in the same exact case after the assert.

Example failure:

00:00 �[32m+12�[0m�[31m -1�[0m: test/skia_gold_client_test.dart: fails if GOLDCTL is not set �[1m�[31m[E]�[0m�[0m
  'package:skia_gold_client/skia_gold_client.dart': Failed assertion: line 193 pos 7: 'isAvailable(environment: _environment)': Trying to use `goldctl` in an environment where it is not available
  dart:core                                             _AssertionError._throwNew
  package:skia_gold_client/skia_gold_client.dart 193:7  SkiaGoldClient._goldctl
  package:skia_gold_client/skia_gold_client.dart 212:7  SkiaGoldClient.auth
  test/skia_gold_client_test.dart 85:22                 main.<fn>

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2024
@auto-submit auto-submit bot merged commit 9838d3c into flutter:main Sep 4, 2024
34 checks passed
@matanlurey matanlurey deleted the pkg-test-more-more branch September 4, 2024 22:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 5, 2024
…154653)

flutter/engine@4a01a3a...652a43b

2024-09-04 [email protected] Manual roll Dart SDK from 139867e57ba9 to 1a6246225b75 (18 revisions) (flutter/engine#54962)
2024-09-04 [email protected] Framework wide color linear gradients (flutter/engine#54748)
2024-09-04 [email protected] Add more `package:test` (removing usages of `package:litetest`) (flutter/engine#54882)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants