Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Test running the macOS engine has no stray logging" #54778

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Revert "Test running the macOS engine has no stray logging" #54778

merged 1 commit into from
Aug 26, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 26, 2024 •
edited
Loading

This reverts commit 5aed693.

Revert #54716. This new check is flaking and isn't very high-value.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738562907128595441/+/u/test:_Host_Tests_for_host_profile/stdout

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cbracken
cbracken approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@auto-submit auto-submit bot merged commit 9fb55ef into flutter:main Aug 26, 2024
29 checks passed
@jmagman jmagman deleted the revert-macos-log branch August 26, 2024 18:00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
9fb55ef52 Revert "Test running the macOS engine has no stray logging" (…
d3895c3 
…flutter/engine#54778)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
9fb55ef52 Revert "Test running the macOS engine has no stray logging" (…
bc132c1 
…flutter/engine#54778)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
Manual roll Flutter Engine from 365b0c70faf5 to f645ca5d8433 (19 revi…
988fefd 
…sions) (#154137)

Manual roll requested by [email protected]

flutter/engine@365b0c7...f645ca5

2024-08-26 [email protected] Revert dart to b81b344a194f (flutter/engine#54782)
2024-08-26 [email protected] [web] set the "dialog" ARIA role unconditionally (flutter/engine#54761)
2024-08-26 [email protected] Revert "Test running the macOS engine has no stray logging" (flutter/engine#54778)
2024-08-26 [email protected] clangd_check: write .clangd as part of test (flutter/engine#54766)
2024-08-26 [email protected] Roll Dart SDK from c7eb3230248a to 94c21ec02e28 (2 revisions) (flutter/engine#54776)
2024-08-26 [email protected] [Android] Drops semantics query when app is not attached (flutter/engine#52040)
2024-08-26 [email protected] [ui] fix missing color conversion in drawAtlas. (flutter/engine#54750)
2024-08-26 [email protected] Roll Skia from ce0656c1d79c to a05dbd2a60f0 (3 revisions) (flutter/engine#54774)
2024-08-26 [email protected] Roll Fuchsia Linux SDK from CVnRW3RAZuTq0lVaw... to QqRZlA9wVbeg4WoPz... (flutter/engine#54770)
2024-08-26 [email protected] [Impeller] delete impeller image class. (flutter/engine#54767)
2024-08-25 [email protected] [Impeller] more test migration. (flutter/engine#54763)
2024-08-25 [email protected] [macOS] Add TODOs to remove AppKit bug workaround (flutter/engine#54764)
2024-08-25 [email protected] Roll Fuchsia Linux SDK from 5uR6WvDV5FX-aZgKQ... to CVnRW3RAZuTq0lVaw... (flutter/engine#54765)
2024-08-24 [email protected] Roll Skia from d59df6f6f4f3 to ce0656c1d79c (2 revisions) (flutter/engine#54760)
2024-08-24 [email protected] Roll Skia from 741972846fa2 to d59df6f6f4f3 (1 revision) (flutter/engine#54758)
2024-08-24 [email protected] Roll Fuchsia Linux SDK from 0d2McFgsNwG-5r1Rb... to 5uR6WvDV5FX-aZgKQ... (flutter/engine#54757)
2024-08-24 [email protected] Roll Dart SDK from 586ba94c96a4 to c7eb3230248a (2 revisions) (flutter/engine#54755)
2024-08-24 [email protected] Roll Skia from 0086a17e0d4c to 741972846fa2 (3 revisions) (flutter/engine#54753)
2024-08-24 [email protected] Roll Dart SDK from b81b344a194f to 586ba94c96a4 (1 revision) (flutter/engine#54752)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 0d2McFgsNwG- to QqRZlA9wVbeg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Manual roll Flutter Engine from 365b0c70faf5 to f645ca5d8433 (19 revi…
207ce89 
…sions) (flutter#154137)

Manual roll requested by [email protected]

flutter/engine@365b0c7...f645ca5

2024-08-26 [email protected] Revert dart to b81b344a194f (flutter/engine#54782)
2024-08-26 [email protected] [web] set the "dialog" ARIA role unconditionally (flutter/engine#54761)
2024-08-26 [email protected] Revert "Test running the macOS engine has no stray logging" (flutter/engine#54778)
2024-08-26 [email protected] clangd_check: write .clangd as part of test (flutter/engine#54766)
2024-08-26 [email protected] Roll Dart SDK from c7eb3230248a to 94c21ec02e28 (2 revisions) (flutter/engine#54776)
2024-08-26 [email protected] [Android] Drops semantics query when app is not attached (flutter/engine#52040)
2024-08-26 [email protected] [ui] fix missing color conversion in drawAtlas. (flutter/engine#54750)
2024-08-26 [email protected] Roll Skia from ce0656c1d79c to a05dbd2a60f0 (3 revisions) (flutter/engine#54774)
2024-08-26 [email protected] Roll Fuchsia Linux SDK from CVnRW3RAZuTq0lVaw... to QqRZlA9wVbeg4WoPz... (flutter/engine#54770)
2024-08-26 [email protected] [Impeller] delete impeller image class. (flutter/engine#54767)
2024-08-25 [email protected] [Impeller] more test migration. (flutter/engine#54763)
2024-08-25 [email protected] [macOS] Add TODOs to remove AppKit bug workaround (flutter/engine#54764)
2024-08-25 [email protected] Roll Fuchsia Linux SDK from 5uR6WvDV5FX-aZgKQ... to CVnRW3RAZuTq0lVaw... (flutter/engine#54765)
2024-08-24 [email protected] Roll Skia from d59df6f6f4f3 to ce0656c1d79c (2 revisions) (flutter/engine#54760)
2024-08-24 [email protected] Roll Skia from 741972846fa2 to d59df6f6f4f3 (1 revision) (flutter/engine#54758)
2024-08-24 [email protected] Roll Fuchsia Linux SDK from 0d2McFgsNwG-5r1Rb... to 5uR6WvDV5FX-aZgKQ... (flutter/engine#54757)
2024-08-24 [email protected] Roll Dart SDK from 586ba94c96a4 to c7eb3230248a (2 revisions) (flutter/engine#54755)
2024-08-24 [email protected] Roll Skia from 0086a17e0d4c to 741972846fa2 (3 revisions) (flutter/engine#54753)
2024-08-24 [email protected] Roll Dart SDK from b81b344a194f to 586ba94c96a4 (1 revision) (flutter/engine#54752)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 0d2McFgsNwG- to QqRZlA9wVbeg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbracken cbracken cbracken approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

Assignees
No one assigned
Labels
affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @cbracken @loic-sharma