This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
[web:semantics] fix double click due to long-press #54697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Aug 22, 2024
Co-authored-by: Mouad Debbar <[email protected]>
yjbanov
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2024
pedromassango
added
the
cp: stable
flutteractionsbot
pushed a commit
to flutteractionsbot/engine
that referenced
this pull request
Aug 23, 2024
Remember the timestamp of _all_ `pointerup` events, not just those that were flushed. Clicks should be deduplicated after a `pointerup` even when not debouncing anything. This is because when not debouncing the engine already forwards all the pointer events to the framework, and sending click events on top only causes double-clicks. Fixes flutter/flutter#147050
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 23, 2024
…153994) flutter/engine@67a7fe1...e4fac78 2024-08-23 [email protected] Revert "Framework wide color" (flutter/engine#54728) 2024-08-23 [email protected] Roll Skia from 7ac776072577 to 7d96b8516e8d (3 revisions) (flutter/engine#54731) 2024-08-23 [email protected] Roll Skia from 789f5cb0b9c2 to 7ac776072577 (1 revision) (flutter/engine#54729) 2024-08-23 [email protected] Roll Skia from b25553b2fb9f to 789f5cb0b9c2 (1 revision) (flutter/engine#54726) 2024-08-23 [email protected] Roll Dart SDK from ca009736fb3e to f9e6abb21ac7 (1 revision) (flutter/engine#54725) 2024-08-23 [email protected] [Impeller] Reland 3: Implement draw order optimization. (flutter/engine#54673) 2024-08-23 [email protected] Roll Fuchsia Test Scripts from 2fOjXGNxdSoRSGCL7... to 2TaLkdJNlAIbDYccn... (flutter/engine#54721) 2024-08-23 [email protected] Roll Fuchsia GN SDK from sbh76PYVTMxav4ACT... to OKGFjciA5Vd0TQks4... (flutter/engine#54722) 2024-08-22 [email protected] Test running the macOS engine has no stray logging (flutter/engine#54716) 2024-08-22 [email protected] Roll Dart SDK from 937389f7bc48 to ca009736fb3e (1 revision) (flutter/engine#54719) 2024-08-22 [email protected] More diagnostic clean ups (flutter/engine#54265) 2024-08-22 [email protected] Framework wide color (flutter/engine#54415) 2024-08-22 [email protected] Roll Skia from 10e9072dcea0 to b25553b2fb9f (2 revisions) (flutter/engine#54717) 2024-08-22 [email protected] Roll Dart SDK from ce160bf13347 to 937389f7bc48 (1 revision) (flutter/engine#54715) 2024-08-22 [email protected] [web:semantics] fix double click due to long-press (flutter/engine#54697) 2024-08-22 [email protected] Roll Skia from 04ce2e2bfc35 to 10e9072dcea0 (1 revision) (flutter/engine#54713) 2024-08-22 [email protected] Pin mac host and iOS builds to arm64 builders (flutter/engine#54711) 2024-08-22 [email protected] macOS: Bundle dSYM packages in FlutterMacOS.xcframework (flutter/engine#54696) 2024-08-22 [email protected] Roll Skia from 7611984dc27b to 04ce2e2bfc35 (2 revisions) (flutter/engine#54712) 2024-08-22 [email protected] vulkan_glfw validation layer logging (flutter/engine#54607) 2024-08-22 [email protected] Roll Skia from 4c66b7e42027 to 7611984dc27b (1 revision) (flutter/engine#54710) 2024-08-22 [email protected] Roll Dart SDK from 025bf8d376d3 to ce160bf13347 (1 revision) (flutter/engine#54709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153994) flutter/engine@67a7fe1...e4fac78 2024-08-23 [email protected] Revert "Framework wide color" (flutter/engine#54728) 2024-08-23 [email protected] Roll Skia from 7ac776072577 to 7d96b8516e8d (3 revisions) (flutter/engine#54731) 2024-08-23 [email protected] Roll Skia from 789f5cb0b9c2 to 7ac776072577 (1 revision) (flutter/engine#54729) 2024-08-23 [email protected] Roll Skia from b25553b2fb9f to 789f5cb0b9c2 (1 revision) (flutter/engine#54726) 2024-08-23 [email protected] Roll Dart SDK from ca009736fb3e to f9e6abb21ac7 (1 revision) (flutter/engine#54725) 2024-08-23 [email protected] [Impeller] Reland 3: Implement draw order optimization. (flutter/engine#54673) 2024-08-23 [email protected] Roll Fuchsia Test Scripts from 2fOjXGNxdSoRSGCL7... to 2TaLkdJNlAIbDYccn... (flutter/engine#54721) 2024-08-23 [email protected] Roll Fuchsia GN SDK from sbh76PYVTMxav4ACT... to OKGFjciA5Vd0TQks4... (flutter/engine#54722) 2024-08-22 [email protected] Test running the macOS engine has no stray logging (flutter/engine#54716) 2024-08-22 [email protected] Roll Dart SDK from 937389f7bc48 to ca009736fb3e (1 revision) (flutter/engine#54719) 2024-08-22 [email protected] More diagnostic clean ups (flutter/engine#54265) 2024-08-22 [email protected] Framework wide color (flutter/engine#54415) 2024-08-22 [email protected] Roll Skia from 10e9072dcea0 to b25553b2fb9f (2 revisions) (flutter/engine#54717) 2024-08-22 [email protected] Roll Dart SDK from ce160bf13347 to 937389f7bc48 (1 revision) (flutter/engine#54715) 2024-08-22 [email protected] [web:semantics] fix double click due to long-press (flutter/engine#54697) 2024-08-22 [email protected] Roll Skia from 04ce2e2bfc35 to 10e9072dcea0 (1 revision) (flutter/engine#54713) 2024-08-22 [email protected] Pin mac host and iOS builds to arm64 builders (flutter/engine#54711) 2024-08-22 [email protected] macOS: Bundle dSYM packages in FlutterMacOS.xcframework (flutter/engine#54696) 2024-08-22 [email protected] Roll Skia from 7611984dc27b to 04ce2e2bfc35 (2 revisions) (flutter/engine#54712) 2024-08-22 [email protected] vulkan_glfw validation layer logging (flutter/engine#54607) 2024-08-22 [email protected] Roll Skia from 4c66b7e42027 to 7611984dc27b (1 revision) (flutter/engine#54710) 2024-08-22 [email protected] Roll Dart SDK from 025bf8d376d3 to ce160bf13347 (1 revision) (flutter/engine#54709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember the timestamp of all
pointerupevents, not just those that were flushed. Clicks should be deduplicated after apointerupeven when not debouncing anything. This is because when not debouncing the engine already forwards all the pointer events to the framework, and sending click events on top only causes double-clicks.Fixes flutter/flutter#147050