This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Cherrypick entitlements file fix to 3.24 branch #54585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In flutter#54414, we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds, but did not add the dSYMs to the without_entitlements.txt list. This passed all engine pre/post-submit tests, as well as framework tests, but failed during release codesigning in Cocoon in a test here: https://github.com/flutter/cocoon/blob/d849b14bab90e0f90e2f7667e37c9f9a5696b918/cipd_packages/codesign/lib/src/file_codesign_visitor.dart#L305-L313 This adds the missing files to without_entitlements.txt. Issue: flutter/flutter#116493 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
github-actions
bot
added
platform-ios
platform-web
|
This looks like a fair bit more than an entitlements fix -- is that expected? |
christopherfujino
changed the base branch from
main
to
flutter-3.24-candidate.0
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
wrong merge target :) |
|
This should base from flutter-3.24-candidate.0 |
itsjustkevin
approved these changes
Aug 16, 2024
christopherfujino
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/54585, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Wb tests are failing with: |
Ok, I think this was broken by https://github.com/flutter/engine/pull/54571/files, which coincidentally didn't run "Linux Web Framework tests" |
|
So, I believe I pushed an empty commit and confirmed that this target was not scheduled. |
christopherfujino
added
the
autosubmit
auto-submit
bot
merged commit c9b9d57
into
flutter:flutter-3.24-candidate.0
26 checks passed
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#153532
Cherrypicks #54573 (from flutter-3.24-candidate.1 branch) to the 3.24 stable candidate branch.