This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
[iOS][macOS] Eliminate use of bitcode_strip #54254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Jul 31, 2024
cbracken
added
the
autosubmit
cbracken
force-pushed
the
no-bitcode_strip
branch
from
0c9b87e to
6355470
Compare
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location. Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details. This is a reland of flutter#54240 which was reverted in flutter#54250 The the previous version was reverted because Python's `shutil.copyfile` doesn't set the unix permissions of the source file on the destination file. However, when overwriting an existing destination file, it preserves any permissions on that file. One can imagine how this might be problematic if you test the script by running before and after the change with the same output directory. `shutil.copy2` attempts to preserve source file metadata when writing the copy. Issue: flutter/flutter#107884
cbracken
force-pushed
the
no-bitcode_strip
branch
from
6355470 to
cd58455
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2024
…sions) (#152648) Manual roll requested by [email protected] flutter/engine@1633272...32f7888 2024-07-31 [email protected] Roll Skia from 431b57332241 to b5ad5bf3696d (3 revisions) (flutter/engine#54259) 2024-07-31 [email protected] Roll Fuchsia Linux SDK from cYjTzxe0MskG7PtkB... to uF76DfQgigt4utdBv... (flutter/engine#54258) 2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Reland: Implement draw order optimization. (#54215)" (flutter/engine#54261) 2024-07-31 [email protected] Roll Skia from cd58e87c06f9 to 431b57332241 (2 revisions) (flutter/engine#54257) 2024-07-31 [email protected] [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54254) 2024-07-31 [email protected] Roll Skia from e9e423457655 to cd58e87c06f9 (5 revisions) (flutter/engine#54253) 2024-07-31 [email protected] Cleanup the shell test, removing unused code (flutter/engine#54238) 2024-07-31 [email protected] [web] rename dialog to route to match the framework (flutter/engine#54228) 2024-07-31 [email protected] Roll Dart SDK from edace067d950 to 5df6a6e0c037 (1 revision) (flutter/engine#54252) 2024-07-31 [email protected] [Impeller] Reland: Implement draw order optimization. (flutter/engine#54215) 2024-07-31 [email protected] Migrate the remaining real pub packages to pub workspaces. (flutter/engine#54232) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from cYjTzxe0MskG to uF76DfQgigt4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…sions) (flutter#152648) Manual roll requested by [email protected] flutter/engine@1633272...32f7888 2024-07-31 [email protected] Roll Skia from 431b57332241 to b5ad5bf3696d (3 revisions) (flutter/engine#54259) 2024-07-31 [email protected] Roll Fuchsia Linux SDK from cYjTzxe0MskG7PtkB... to uF76DfQgigt4utdBv... (flutter/engine#54258) 2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Reland: Implement draw order optimization. (flutter#54215)" (flutter/engine#54261) 2024-07-31 [email protected] Roll Skia from cd58e87c06f9 to 431b57332241 (2 revisions) (flutter/engine#54257) 2024-07-31 [email protected] [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54254) 2024-07-31 [email protected] Roll Skia from e9e423457655 to cd58e87c06f9 (5 revisions) (flutter/engine#54253) 2024-07-31 [email protected] Cleanup the shell test, removing unused code (flutter/engine#54238) 2024-07-31 [email protected] [web] rename dialog to route to match the framework (flutter/engine#54228) 2024-07-31 [email protected] Roll Dart SDK from edace067d950 to 5df6a6e0c037 (1 revision) (flutter/engine#54252) 2024-07-31 [email protected] [Impeller] Reland: Implement draw order optimization. (flutter/engine#54215) 2024-07-31 [email protected] Migrate the remaining real pub packages to pub workspaces. (flutter/engine#54232) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from cYjTzxe0MskG to uF76DfQgigt4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…sions) (flutter#152648) Manual roll requested by [email protected] flutter/engine@1633272...32f7888 2024-07-31 [email protected] Roll Skia from 431b57332241 to b5ad5bf3696d (3 revisions) (flutter/engine#54259) 2024-07-31 [email protected] Roll Fuchsia Linux SDK from cYjTzxe0MskG7PtkB... to uF76DfQgigt4utdBv... (flutter/engine#54258) 2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Reland: Implement draw order optimization. (flutter#54215)" (flutter/engine#54261) 2024-07-31 [email protected] Roll Skia from cd58e87c06f9 to 431b57332241 (2 revisions) (flutter/engine#54257) 2024-07-31 [email protected] [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54254) 2024-07-31 [email protected] Roll Skia from e9e423457655 to cd58e87c06f9 (5 revisions) (flutter/engine#54253) 2024-07-31 [email protected] Cleanup the shell test, removing unused code (flutter/engine#54238) 2024-07-31 [email protected] [web] rename dialog to route to match the framework (flutter/engine#54228) 2024-07-31 [email protected] Roll Dart SDK from edace067d950 to 5df6a6e0c037 (1 revision) (flutter/engine#54252) 2024-07-31 [email protected] [Impeller] Reland: Implement draw order optimization. (flutter/engine#54215) 2024-07-31 [email protected] Migrate the remaining real pub packages to pub workspaces. (flutter/engine#54232) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from cYjTzxe0MskG to uF76DfQgigt4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our executables are no longer built with bitcode enabled and thus
bitcode_strip -r SOURCE -o DESTis just copying the file in question to the output location.Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.
This is a reland of #54240 which was reverted in #54250.
The the previous version was reverted because Python's
shutil.copyfiledoesn't set the unix permissions of the source file on the destination file. However, when overwriting an existing destination file, it preserves any permissions on that file. One can imagine how this might be problematic if you test the script by running before and after the change with the same output directory.shutil.copy2attempts to preserve source file metadata when writing the copy.Issue: flutter/flutter#107884
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.