Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Reverts "[iOS][macOS] Eliminate use of bitcode_strip (#54240)" #54250

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Reverts "[iOS][macOS] Eliminate use of bitcode_strip (#54240)" #54250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sky/tools/create_full_ios_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def _generate_gen_snapshot(gen_snapshot_path, destination):
print('Cannot find gen_snapshot at %s' % gen_snapshot_path)
sys.exit(1)

shutil.copyfile(gen_snapshot_path, destination)
subprocess.check_call(['xcrun', 'bitcode_strip', '-r', gen_snapshot_path, '-o', destination])


if __name__ == '__main__':
Expand Down
3 changes: 1 addition & 2 deletions sky/tools/create_macos_gen_snapshots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
# found in the LICENSE file.

import argparse
import shutil
import subprocess
import sys
import os
Expand Down Expand Up @@ -70,7 +69,7 @@ def generate_gen_snapshot(gen_snapshot_path, destination):
print('Cannot find gen_snapshot at %s' % gen_snapshot_path)
sys.exit(1)

shutil.copyfile(gen_snapshot_path, destination)
subprocess.check_call(['xcrun', 'bitcode_strip', '-r', gen_snapshot_path, '-o', destination])


if __name__ == '__main__':
Expand Down