This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
[skwasm] Fix platform view occlusion logic. #54061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Jul 24, 2024
|
|
||
| @override | ||
| ui.Rect inverseMapRect(ui.Rect rect) => rect; | ||
| ui.Rect mapRect(ui.Rect contentRect) => (filter as SceneImageFilter).filterBounds(contentRect); |
There was a problem hiding this comment.
Should we cast it in the constructor so we don't have to cast on every usage?
| final Matrix4 matrix = getMatrix()..invert(); | ||
| return matrix.transformRect(rect); | ||
| } | ||
| ui.Rect mapRect(ui.Rect contentRect) => getMatrix().transformRect(contentRect); |
There was a problem hiding this comment.
Is the matrix immutable? If so, can we create the matrix in the constructor and reuse it when rendering?
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2024
…152260) flutter/engine@490576d...c2f489d 2024-07-24 [email protected] Fix embedder comments about struct_size (flutter/engine#54077) 2024-07-24 [email protected] share platform view slicing logic across iOS and Android. (flutter/engine#54010) 2024-07-24 [email protected] [skwasm] Fix platform view occlusion logic. (flutter/engine#54061) 2024-07-24 [email protected] Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081) 2024-07-24 [email protected] Upgrade Engine Android SDK to 35 (flutter/engine#53574) 2024-07-24 [email protected] Roll Skia from a9b1043eb23e to 25f26f673502 (1 revision) (flutter/engine#54079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152260) flutter/engine@490576d...c2f489d 2024-07-24 [email protected] Fix embedder comments about struct_size (flutter/engine#54077) 2024-07-24 [email protected] share platform view slicing logic across iOS and Android. (flutter/engine#54010) 2024-07-24 [email protected] [skwasm] Fix platform view occlusion logic. (flutter/engine#54061) 2024-07-24 [email protected] Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081) 2024-07-24 [email protected] Upgrade Engine Android SDK to 35 (flutter/engine#53574) 2024-07-24 [email protected] Roll Skia from a9b1043eb23e to 25f26f673502 (1 revision) (flutter/engine#54079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Rexios80
pushed a commit
to Rexios80/flutter_engine
that referenced
this pull request
Aug 29, 2024
The occlusion rectangle for platform views was going through this `inverseMapRect` code path, which actually was giving us the wrong results. The operations should just be doing the normal transformation on the rectangles to get the right result. It actually turns out we don't need the inverse mapping function, so I removed it, and I renamed the somewhat confusingly named `cullRect` function to `mapRect` which I think makes a bit more sense. This should resolve flutter/flutter#152139
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152260) flutter/engine@490576d...c2f489d 2024-07-24 [email protected] Fix embedder comments about struct_size (flutter/engine#54077) 2024-07-24 [email protected] share platform view slicing logic across iOS and Android. (flutter/engine#54010) 2024-07-24 [email protected] [skwasm] Fix platform view occlusion logic. (flutter/engine#54061) 2024-07-24 [email protected] Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081) 2024-07-24 [email protected] Upgrade Engine Android SDK to 35 (flutter/engine#53574) 2024-07-24 [email protected] Roll Skia from a9b1043eb23e to 25f26f673502 (1 revision) (flutter/engine#54079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The occlusion rectangle for platform views was going through this
inverseMapRectcode path, which actually was giving us the wrong results. The operations should just be doing the normal transformation on the rectangles to get the right result. It actually turns out we don't need the inverse mapping function, so I removed it, and I renamed the somewhat confusingly namedcullRectfunction tomapRectwhich I think makes a bit more sense.This should resolve flutter/flutter#152139