Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Update docs to use new Gradle version in the engine #53964

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Update docs to use new Gradle version in the engine #53964

merged 4 commits into from
Aug 5, 2024

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jul 17, 2024 •
edited
Loading

Updates/corrects steps to update Gradle version used in the engine based on what @gmackall and I did to update the engine's Gradle version in #53574.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@camsim99 camsim99 marked this pull request as ready for review July 31, 2024 22:22
@camsim99 camsim99 requested a review from a team July 31, 2024 22:22
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@auto-submit auto-submit bot merged commit f6aeec2 into flutter:main Aug 5, 2024
29 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2024
@engine-flutter-autoroll
f6aeec26f Update docs to use new Gradle version in the engine (flutte…
8474710 
…r/engine#53964)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 5, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 1bfd06cda313 to e073ad2e3ad4 (4 revisions) (#…
84eb378 
…152889)

flutter/engine@1bfd06c...e073ad2

2024-08-05 [email protected] Roll Dart SDK from bdeaec130e8e to 71e84a69ce6d (1 revision) (flutter/engine#54349)
2024-08-05 [email protected] Roll Skia from c908f20dc0b1 to f3406766fa23 (2 revisions) (flutter/engine#54348)
2024-08-05 [email protected] Roll Skia from 938b8b8efdfa to c908f20dc0b1 (1 revision) (flutter/engine#54347)
2024-08-05 [email protected] Update docs to use new Gradle version in the engine (flutter/engine#53964)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll @TytaniumDev
Roll Flutter Engine from 1bfd06cda313 to e073ad2e3ad4 (4 revisions) (f…
93b5595 
…lutter#152889)

flutter/engine@1bfd06c...e073ad2

2024-08-05 [email protected] Roll Dart SDK from bdeaec130e8e to 71e84a69ce6d (1 revision) (flutter/engine#54349)
2024-08-05 [email protected] Roll Skia from c908f20dc0b1 to f3406766fa23 (2 revisions) (flutter/engine#54348)
2024-08-05 [email protected] Roll Skia from 938b8b8efdfa to c908f20dc0b1 (1 revision) (flutter/engine#54347)
2024-08-05 [email protected] Update docs to use new Gradle version in the engine (flutter/engine#53964)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Flutter Engine from 1bfd06cda313 to e073ad2e3ad4 (4 revisions) (f…
4f2bfd9 
…lutter#152889)

flutter/engine@1bfd06c...e073ad2

2024-08-05 [email protected] Roll Dart SDK from bdeaec130e8e to 71e84a69ce6d (1 revision) (flutter/engine#54349)
2024-08-05 [email protected] Roll Skia from c908f20dc0b1 to f3406766fa23 (2 revisions) (flutter/engine#54348)
2024-08-05 [email protected] Roll Skia from 938b8b8efdfa to c908f20dc0b1 (1 revision) (flutter/engine#54347)
2024-08-05 [email protected] Update docs to use new Gradle version in the engine (flutter/engine#53964)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@gmackall gmackall gmackall approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camsim99 @reidbaker @gmackall