This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Return an empty optional in HardwareBuffer::GetSystemUniqueID if the underlying NDK API is unavailable #51839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Apr 2, 2024
…underlying NDK API is unavailable
jason-simmons
force-pushed
the
bug_b332379081
branch
from
7fab718 to
b4e6f10
Compare
|
Added a test that temporarily disables the API in the proc table |
|
I filed flutter/flutter#146146 to list the current major version breaks. |
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2024
…ID if the underlying NDK API is unavailable (flutter/engine#51839)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 3, 2024
…146169) flutter/engine@5f6dec8...bb4ec2d 2024-04-02 [email protected] Add an engine switch that controls whether the platform isolate API is available. (flutter/engine#51784) 2024-04-02 [email protected] Run `DrawSolidBlueScreenTest` 20x in a row in `bringup` (up from 5x) (flutter/engine#51850) 2024-04-02 [email protected] Return an empty optional in HardwareBuffer::GetSystemUniqueID if the underlying NDK API is unavailable (flutter/engine#51839) 2024-04-02 [email protected] Use `fml::ScopedCleanupClosure` instead of `DeathRattle`. (flutter/engine#51834) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jasguerrero
pushed a commit
to Jasguerrero/engine
that referenced
this pull request
Apr 4, 2024
…underlying NDK API is unavailable (flutter#51839)
Jasguerrero
pushed a commit
to Jasguerrero/engine
that referenced
this pull request
Apr 4, 2024
…underlying NDK API is unavailable (flutter#51839)
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
… the … (#51910) b/332810673 â�¦underlying NDK API is unavailable (#51839) *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Jasguerrero
pushed a commit
to Jasguerrero/engine
that referenced
this pull request
Apr 4, 2024
…underlying NDK API is unavailable (flutter#51839)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.