This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add AbsorbOpacity enum. #45838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
force-pushed
the
bdero/absorb-opacity-enum
branch
from
1617874 to
0c9d606
Compare
chinmaygarde
approved these changes
Sep 14, 2023
|
auto label is removed for flutter/engine/45838, due to - The status or check suite Linux linux_arm_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
bdero
force-pushed
the
bdero/absorb-opacity-enum
branch
from
0c9d606 to
195cde7
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 14, 2023
…134778) flutter/engine@3a3a280...683bca5 2023-09-14 [email protected] [Impeller] Assert IMPELLER_ENABLE_3D when importing scene_contents.h. (flutter/engine#45848) 2023-09-14 [email protected] Roll Skia from 0f003d5748bc to 6bc9f5886ddf (2 revisions) (flutter/engine#45847) 2023-09-14 [email protected] [Impeller] Add AbsorbOpacity enum. (flutter/engine#45838) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#134778) flutter/engine@3a3a280...683bca5 2023-09-14 [email protected] [Impeller] Assert IMPELLER_ENABLE_3D when importing scene_contents.h. (flutter/engine#45848) 2023-09-14 [email protected] Roll Skia from 0f003d5748bc to 6bc9f5886ddf (2 revisions) (flutter/engine#45847) 2023-09-14 [email protected] [Impeller] Add AbsorbOpacity enum. (flutter/engine#45838) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#134681.