Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Reland "[web] Render in custom target (#37738)" #38477

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Reland "[web] Render in custom target (#37738)" #38477

merged 2 commits into from
Dec 23, 2022

Conversation

ditman
Copy link
Member

@ditman ditman commented Dec 23, 2022

This PR fixes an html renderer bug introduced in the feature above that was breaking the following flutter/flutter golden tests:

*  24 - value_indicating_slider_test.dart (material.slider_...)
*   1 - material/magnifier_test.dart (material.magnifier.position...)
*   8 - snack_bar_test.dart (material.snack_bar...)
*   1 - material/text_field_test.dart (material.text_field_golden...) (missing 'debug' label?)
*   2 - viewport_test.dart (rendering.shrink_wrap...)
*   2 - star_border_test.dart (painting.star_border....)
*   2 - image_filter_test.dart (widgets.image_filter_blur_...) (antialias? _offset?)
*   1 - page_route_builder_test.dart (widgets.page_route_builder...)
*   1 - overscroll_stretch_indicator_test.dart (widgets.overscroll_...)
*   1 - physical_model_test.dart (widgets.physical_model_overflow...) (antialias?)
*   1 - list_wheel_scroll_view_test.dart (widgets.list_wheel_scroll_view...)
*   1 - cupertino/magnifier_test.dart (cupertino_magnifier.position...)

This PR relands #37738 (by reverting #38469, and adding a small fix).

Find attached the resulting "golden" files used to verify that the above tests would now pass:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from yjbanov December 23, 2022 03:08
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Dec 23, 2022
yjbanov
yjbanov approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 23, 2022
@auto-submit auto-submit bot merged commit 5bae183 into flutter:main Dec 23, 2022
@ditman ditman deleted the reland-render-in-custom-target branch December 23, 2022 18:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 23, 2022
@engine-flutter-autoroll
5bae18365 Reland "[web] Render in custom target (flutter#37738)" (flu…
6976c13 
…tter/engine#38477)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 23, 2022
@engine-flutter-autoroll
5bae18365 Reland "[web] Render in custom target (#37738)" (flutter/en…
b3c321f 
…gine#38477) (#117600)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Dec 23, 2022
flutter: 5bae18365 Reland "[web] Render in custom target (#37738)" (f…
6b03e18 
…lutter/engine#38477) (#117600)

Commit: b3c321f1dc4737168a34cf39711916eba3cabc47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 24, 2022
@engine-flutter-autoroll
b3c321f 5bae18365 Reland "[web] Render in custom target (#37738)" (fl…
72a2965 
…utter/engine#38477) (flutter/flutter#117600)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Dec 26, 2022
@engine-flutter-autoroll
Roll Flutter from a45a2f3 to e766ad0 (7 revisions) (#6880)
3eba2bf 
* dec6b27 94a54bf Roll Flutter from dbc9306 to 9fb1ae8 (106 revisions) (#6876) (flutter/flutter#117598)

* b3c321f 5bae18365 Reland "[web] Render in custom target (#37738)" (flutter/engine#38477) (flutter/flutter#117600)

* 4b4783d [flutter roll] Revert both #117338 and #117547 (flutter/flutter#117557)

* 102d039 77db88672 Roll Fuchsia Mac SDK from 9w7QDlttR9f7Gu7U6... to 9qjOKSNAN2EiCgQxC... (flutter/engine#38487) (flutter/flutter#117603)

* 393e156 e3edfadbd Roll Dart SDK from 442614a6c1bb to 6340d946feac (1 revision) (flutter/engine#38489) (flutter/flutter#117604)

* bc7d275 1d5c44966 Roll Skia from a8b7ce3b6391 to 38d9c68d35c6 (2 revisions) (flutter/engine#38492) (flutter/flutter#117617)

* e766ad0 6bee6d768 Roll Fuchsia Mac SDK from 9qjOKSNAN2EiCgQxC... to hGNNd-oOWFLY86Tnl... (flutter/engine#38493) (flutter/flutter#117618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 27, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 27, 2022
@engine-flutter-autoroll
b3c321f 5bae18365 Reland "[web] Render in custom target (#37738)" (fl…
a833877 
…utter/engine#38477) (flutter/flutter#117600)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 27, 2022
@engine-flutter-autoroll
Roll Flutter from a45a2f3 to 894ea20 (28 revisions) (#3006)
0761453 
* dec6b27 94a54bf Roll Flutter from dbc9306 to 9fb1ae8 (106 revisions) (flutter/plugins#6876) (flutter/flutter#117598)

* b3c321f 5bae18365 Reland "[web] Render in custom target (#37738)" (flutter/engine#38477) (flutter/flutter#117600)

* 4b4783d [flutter roll] Revert both #117338 and #117547 (flutter/flutter#117557)

* 102d039 77db88672 Roll Fuchsia Mac SDK from 9w7QDlttR9f7Gu7U6... to 9qjOKSNAN2EiCgQxC... (flutter/engine#38487) (flutter/flutter#117603)

* 393e156 e3edfadbd Roll Dart SDK from 442614a6c1bb to 6340d946feac (1 revision) (flutter/engine#38489) (flutter/flutter#117604)

* bc7d275 1d5c44966 Roll Skia from a8b7ce3b6391 to 38d9c68d35c6 (2 revisions) (flutter/engine#38492) (flutter/flutter#117617)

* e766ad0 6bee6d768 Roll Fuchsia Mac SDK from 9qjOKSNAN2EiCgQxC... to hGNNd-oOWFLY86Tnl... (flutter/engine#38493) (flutter/flutter#117618)

* 484858b 00ce1fd6d add virtual destructor to new virtual Culler class (flutter/engine#38494) (flutter/flutter#117624)

* d674a46 b2968296a Roll Fuchsia Mac SDK from hGNNd-oOWFLY86Tnl... to kV1stXDqE4asMxgjK... (flutter/engine#38495) (flutter/flutter#117626)

* 239f80e 3ae55014f Roll Fuchsia Mac SDK from kV1stXDqE4asMxgjK... to 90MsGucOMFZ_grNUC... (flutter/engine#38498) (flutter/flutter#117633)

* def09b4 b61200484 Roll Fuchsia Mac SDK from 90MsGucOMFZ_grNUC... to QOdpfMkM_LcPon_zm... (flutter/engine#38499) (flutter/flutter#117646)

* a09faa1 Roll Flutter Engine from b61200484d28 to da181dfbfb27 (4 revisions) (flutter/flutter#117651)

* ae292cc Roll Plugins from 94a54bf to 3eba2bf (4 revisions) (flutter/flutter#117653)

* fe3e93e eb8e52c59 Roll Fuchsia Mac SDK from QOdpfMkM_LcPon_zm... to ozbhYRHpQKfnPwJdh... (flutter/engine#38505) (flutter/flutter#117658)

* 41d1911 becee173e Roll Skia from 7442335dce20 to eeec7a127312 (1 revision) (flutter/engine#38506) (flutter/flutter#117662)

* d15db15 84043c672 Roll Skia from eeec7a127312 to 7fe57dac0702 (1 revision) (flutter/engine#38508) (flutter/flutter#117665)

* 4cce45f 06b2eff9d Roll Dart SDK from 6340d946feac to 494e4d4bf58d (1 revision) (flutter/engine#38509) (flutter/flutter#117667)

* d947687 893e48763 Roll Skia from 7fe57dac0702 to 8099f53e7a43 (1 revision) (flutter/engine#38510) (flutter/flutter#117668)

* a7cc010 dbb5a5739 Roll Fuchsia Mac SDK from ozbhYRHpQKfnPwJdh... to HHADjSDGmZSkODScd... (flutter/engine#38511) (flutter/flutter#117669)

* c3f0c13 dcde1faa8 Roll Skia from 8099f53e7a43 to 789552988917 (1 revision) (flutter/engine#38512) (flutter/flutter#117672)

* 91c3f80 790604a09 Roll Skia from 789552988917 to 6abfcf819da1 (2 revisions) (flutter/engine#38513) (flutter/flutter#117674)

* bf2701d 9d69a91bb Roll Dart SDK from 494e4d4bf58d to 742e1dc3e17f (1 revision) (flutter/engine#38514) (flutter/flutter#117681)

* 00e9cf1 e11cb24 Roll Flutter from e766ad0 to ae292cc (6 revisions) (flutter/plugins#6885) (flutter/flutter#117682)

* 5538fa1 c54228b5c Roll Skia from 6abfcf819da1 to 4f64211cd741 (1 revision) (flutter/engine#38515) (flutter/flutter#117684)

* 1c273fb 27ebaec7d Roll Skia from 4f64211cd741 to 3939e68c4b4d (2 revisions) (flutter/engine#38517) (flutter/flutter#117686)

* f11fbba [macOS] Fix the `run_debug_test_macos` on arm64 (flutter/flutter#117250)

* d7abc0b a53f1e983 Roll Skia from 3939e68c4b4d to 2b6d44eb650b (2 revisions) (flutter/engine#38519) (flutter/flutter#117689)

* 894ea20 e049bbf41 Roll Fuchsia Mac SDK from HHADjSDGmZSkODScd... to c1-ICa-ToxzhYLG7F... (flutter/engine#38520) (flutter/flutter#117690)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
@ditman @loic-sharma
Reland "[web] Render in custom target (flutter#37738)" (flutter#38477)
715c89d 
* Reland "[web] Render in custom target (flutter#37738)"

This reverts commit 3b115f0.

* Use physicalSize instead of logical in localClipBounds of the html scene.
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@engine-flutter-autoroll @loic-sharma
5bae18365 Reland "[web] Render in custom target (flutter#37738)" (flu…
83afaa2 
…tter/engine#38477) (flutter#117600)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
5bae18365 Reland "[web] Render in custom target (flutter#37738)" (flu…
edf1d58 
…tter/engine#38477) (flutter#117600)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from a45a2f3 to e766ad0 (7 revisions) (flutter#6880)
a719494 
* dec6b27 94a54bf Roll Flutter from dbc9306 to 9fb1ae8 (106 revisions) (flutter#6876) (flutter/flutter#117598)

* b3c321f 5bae18365 Reland "[web] Render in custom target (#37738)" (flutter/engine#38477) (flutter/flutter#117600)

* 4b4783d [flutter roll] Revert both #117338 and #117547 (flutter/flutter#117557)

* 102d039 77db88672 Roll Fuchsia Mac SDK from 9w7QDlttR9f7Gu7U6... to 9qjOKSNAN2EiCgQxC... (flutter/engine#38487) (flutter/flutter#117603)

* 393e156 e3edfadbd Roll Dart SDK from 442614a6c1bb to 6340d946feac (1 revision) (flutter/engine#38489) (flutter/flutter#117604)

* bc7d275 1d5c44966 Roll Skia from a8b7ce3b6391 to 38d9c68d35c6 (2 revisions) (flutter/engine#38492) (flutter/flutter#117617)

* e766ad0 6bee6d768 Roll Fuchsia Mac SDK from 9qjOKSNAN2EiCgQxC... to hGNNd-oOWFLY86Tnl... (flutter/engine#38493) (flutter/flutter#117618)
@ditman ditman mentioned this pull request Feb 7, 2024
Open
@dkwingsmt dkwingsmt mentioned this pull request Oct 31, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ditman @yjbanov