[Impeller] Add fenced command buffer that waits on-submit #37750
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iskakaushik
force-pushed
the
resource-management
branch
2 times, most recently
from
a2c4947 to
427684f
Compare
| } | ||
|
|
||
| // cleanup all the resources held by the command buffer and its children. | ||
| deletion_queue_->Flush(); |
There was a problem hiding this comment.
the above fence can be awaited on a different thread similar to https://github.com/chinmaygarde/pixelpusher/blob/master/source/machine/fence_waiter.h, and the deletion queue can be flushed later, but that's an optimization for another day :-)
this isn't ideal for performance long term but aligns well with what the other backends do. This also lets us remove the dependence on frame numbers for renderpasses setting up for implementing MSAA.
iskakaushik
force-pushed
the
resource-management
branch
from
ae3dfdc to
ce7f56e
Compare
|
cc: @chinmaygarde friendly ping |
iskakaushik
added
the
autosubmit
…115949) * 6281b09a7 Roll Fuchsia Mac SDK from zoBKUSYFpDq3XtJZ4... to i-NY382Y0Y8m9OqNp... (flutter/engine#37871) * e74cecbf8 [Impeller] Add fenced command buffer that waits on-submit (flutter/engine#37750)
…lutter#115949) * 6281b09a7 Roll Fuchsia Mac SDK from zoBKUSYFpDq3XtJZ4... to i-NY382Y0Y8m9OqNp... (flutter/engine#37871) * e74cecbf8 [Impeller] Add fenced command buffer that waits on-submit (flutter/engine#37750)
…lutter#115949) * 6281b09a7 Roll Fuchsia Mac SDK from zoBKUSYFpDq3XtJZ4... to i-NY382Y0Y8m9OqNp... (flutter/engine#37871) * e74cecbf8 [Impeller] Add fenced command buffer that waits on-submit (flutter/engine#37750)
this isn't ideal for performance long term but aligns well with what the other backends do. This also lets us remove the dependence on frame numbers for renderpasses setting up for implementing MSAA.
fixes: flutter/flutter#112387