This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
[macOS, Keyboard] Fix Khmer layout crashing #35044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#108729
The previous algorithm queried
usLayoutGoalsByKeyCode
without checking existence.std::map
creates empty entries for these keys in this case, leading to0
logical keys.Also, the previous algorithm checked the entire 128 key codes, which included numpad keys. This allowed mandatory goals for digit keys to be fulfilled by numpad, which is not the intention.
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.