Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

[macOS, Keyboard] Fix Khmer layout crashing #35044

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Aug 1, 2022

Fixes flutter/flutter#108729

The previous algorithm queried usLayoutGoalsByKeyCode without checking existence. std::map creates empty entries for these keys in this case, leading to 0 logical keys.

Also, the previous algorithm checked the entire 128 key codes, which included numpad keys. This allowed mandatory goals for digit keys to be fulfilled by numpad, which is not the intention.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Fix test

Impl
@dkwingsmt dkwingsmt requested a review from gspencergoog August 1, 2022 11:25
@dkwingsmt dkwingsmt marked this pull request as ready for review August 1, 2022 11:25
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] App crashes in Khmer layout
2 participants