This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Remove suppression of null-related warnings #21157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This replaces #19852 which we didn't get to on time and is out of date/has merge conflicts. |
cbracken
force-pushed
the
nnbd-warnings
branch
from
998b93e to
bd67bc4
Compare
Since dart-lang/sdk#41905 has closed, this CL removes the suppression of unnecessary_non_null_assertion and unnecessary_null_comparison. Related issues: dart-lang/sdk#41905 (resolved)
cbracken
force-pushed
the
nnbd-warnings
branch
from
bd67bc4 to
4572e02
Compare
cbracken
added
the
waiting for tree to go green
6 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since dart-lang/sdk#41905 has closed, this CL removes the suppression of
unnecessary_non_null_assertion and unnecessary_null_comparison.
Related issues: dart-lang/sdk#41905 (resolved)