Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goldens #3549

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Update goldens #3549

merged 2 commits into from
Mar 6, 2024

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Mar 6, 2024 •
edited
Loading

The new ColorScheme change causes some golden failures in Cocoon. This PR is to update them.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@QuncCccccc QuncCccccc requested a review from keyonghan March 6, 2024 01:19
keyonghan
keyonghan approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc marked this pull request as ready for review March 6, 2024 17:49
@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App. label Mar 6, 2024
@auto-submit auto-submit bot merged commit b351a5b into main Mar 6, 2024
3 checks passed
sealesj pushed a commit to sealesj/cocoon that referenced this pull request Mar 7, 2024
@QuncCccccc @sealesj
Update goldens (flutter#3549)
6415700 
The new [`ColorScheme` change](flutter/flutter#144273) causes some golden failures in Cocoon. This PR is to update them.
@guidezpl guidezpl deleted the update_goldens branch April 18, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuncCccccc @keyonghan