Follow redirects for ktlint download #3543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github release page is redirecting, so follow the redirects.
Good news, the uploading is working and the cipd package is created: https://chrome-infra-packages.appspot.com/p/flutter/ktlint/linux-amd64
Bad news, the uploaded ktlint file is empty because the curl is failing because we aren't following the redirect.
Passing the
-L
to curl fixes this (I double checked that with-L
passed locally, we download a working version of ktlint). Sorry, should have caught this in the original PR.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.