Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not request tests for engine deletion-only PRs #2490

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Feb 16, 2023

Matches framework repo:

await for (PullRequestFile file in files) {
// When null, do not assume 0 lines have been added.
final String filename = file.filename!;
final int linesAdded = file.additionsCount ?? 1;
final int linesDeleted = file.deletionsCount ?? 0;
final int linesTotal = file.changesCount ?? linesDeleted + linesAdded;
final bool addedCode = linesAdded > 0 || linesDeleted != linesTotal;
if (addedCode &&

and packages repos:

final int linesAdded = file.additionsCount ?? 1;
final int linesDeleted = file.deletionsCount ?? 0;
final int linesTotal = file.changesCount ?? linesDeleted + linesAdded;
final bool addedCode = linesAdded > 0 || linesDeleted != linesTotal;
if (addedCode &&

Would have avoided requesting tests for flutter/engine#39682

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Feb 16, 2023
@jmagman
Copy link
Member Author

jmagman commented Feb 16, 2023

Actually we don't need 3 copies of this logic, I'll DRY it out.

@jmagman jmagman requested a review from CaseyHillers February 16, 2023 17:46
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App. label Feb 16, 2023
@auto-submit auto-submit bot merged commit ba2103f into flutter:main Feb 16, 2023
@jmagman jmagman deleted the delete-engine branch February 16, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants