Make engine build configs test exempt (#3405)

For example for PRs like flutter/engine#49776
flutter · Jan 12, 2024 · 777d7cc · 777d7cc
1 parent 919cc8a
commit 777d7cc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/app_dart/lib/src/request_handlers/github/webhook_subscription.dart b/app_dart/lib/src/request_handlers/github/webhook_subscription.dart
@@ -404,6 +404,8 @@ class GithubWebhookSubscription extends SubscriptionHandler {
           !_isTestExempt(filename) &&
           // License goldens are auto-generated.
           !filename.startsWith('ci/licenses_golden/') &&
+          // Build configuration files tell CI what to run.
+          !filename.startsWith('ci/builders/') &&
           // Build files don't need unit tests.
           !filename.endsWith('.gn') &&
           !filename.endsWith('.gni')) {

diff --git a/app_dart/test/request_handlers/github/webhook_subscription_test.dart b/app_dart/test/request_handlers/github/webhook_subscription_test.dart
@@ -1523,7 +1523,7 @@ void foo() {
       );
     });
 
-    test('Engine labels PRs, no comment for license goldens', () async {
+    test('Engine labels PRs, no comment for license goldens or build configs', () async {
       const int issueNumber = 123;
 
       tester.message = generateGithubWebhookMessage(
@@ -1534,9 +1534,10 @@ void foo() {
       );
 
       when(pullRequestsService.listFiles(Config.engineSlug, issueNumber)).thenAnswer(
-        (_) => Stream<PullRequestFile>.value(
+        (_) => Stream<PullRequestFile>.fromIterable(<PullRequestFile>[
           PullRequestFile()..filename = 'ci/licenses_golden/licenses_dart',
-        ),
+          PullRequestFile()..filename = 'ci/builders/linux_unopt.json',
+        ]),
       );
 
       await tester.post(webhook);