Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ios_deployment_target to iOS 12.0 #808

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Set ios_deployment_target to iOS 12.0 #808

merged 1 commit into from
Jan 4, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jan 3, 2024 •
edited
Loading

Build the engine Flutter.framework against a minimum of iOS 12.
Part of flutter/flutter#140474

Flutter tooling already enforcing iOS 12 on app-end: flutter/flutter#140478

See also #574

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Jan 3, 2024
@jmagman jmagman mentioned this pull request Jan 3, 2024
Closed
8 tasks
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 4, 2024
@auto-submit auto-submit bot merged commit 5dad8ac into flutter:master Jan 4, 2024
@jmagman jmagman deleted the ios-12 branch January 4, 2024 20:57
@jmagman jmagman mentioned this pull request Jan 4, 2024
Merged
8 tasks
auto-submit bot pushed a commit to flutter/engine that referenced this pull request Jan 9, 2024
@jmagman
Roll buildroot to pick up iOS 12 (#49542)
b2ca7bd 
flutter/buildroot#804
flutter/buildroot#806
flutter/buildroot#808
flutter/buildroot#809
flutter/buildroot#810

Engine tests were already running on iOS 13.

Part of flutter/flutter#140474

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@jmagman jmagman mentioned this pull request Jan 12, 2024
Merged
8 tasks
auto-submit bot pushed a commit to flutter/engine that referenced this pull request Jan 16, 2024
@jmagman
Remove iOS 12 availability checks (#49771)
1382ff7 
iOS minimum is now 12: flutter/buildroot#808.  Remove `@available` checks for that version.  

Part of flutter/flutter#140474

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@vashworth vashworth Awaiting requested review from vashworth

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagman @zanderso