Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose rtc video value #30

Merged

Conversation

holzgeist
Copy link
Contributor

It looks like the video track is sometimes rotated internally. Without access to rotation or the computed aspectRatio, it's difficult to know the actual size of the video

It looks like the video track is sometimes rotated internally.
Without access to rotation or the computed aspectRatio, it's
difficult to know the actual size of the video
@holzgeist
Copy link
Contributor Author

If RTCVideoValue should not be exposed on this interface, only exposing aspectRatio (and rotation for good measure?) would also work

Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cloudwebrtc cloudwebrtc merged commit 845fc68 into flutter-webrtc:main Jan 29, 2025
cloudwebrtc pushed a commit to flutter-webrtc/flutter-webrtc that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants