Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webview_flutter_dev] Change method name's first letter #13

Merged
merged 1 commit into from
Dec 24, 2020
Merged

[webview_flutter_dev] Change method name's first letter #13

merged 1 commit into from
Dec 24, 2020

Conversation

seungsoo47
Copy link
Contributor

  • According to convention, I change the method name's the first letter from lower case to upper case.

@seungsoo47
Change method name's first letter
fa9f099 
* According to convention, I change the method name's the first letter from lower case to upper case.
@bwikbs
Copy link
Member

bwikbs commented Dec 23, 2020

Now, Are we satisfied with coding style through this ❓ (Is there anything left?)
BTW, Where can I find the rules regarding this?

@seungsoo47
Copy link
Contributor Author

flutter-tizen/engine#14 (review)
I referred to a comment of @bbrto21 .

@bbrto21
Copy link
Contributor

bbrto21 commented Dec 24, 2020

Now, Are we satisfied with coding style through this (Is there anything left?)
BTW, Where can I find the rules regarding this?

We've been using Google styles since we started this project internally. This is from the flutter project contributing guide

@bbrto21
Copy link
Contributor

bbrto21 commented Dec 24, 2020

We don't have a CI for tidy, so I'd like to avoid mentioning coding styles in the review as much as possible.

bbrto21
bbrto21 approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbrto21 bbrto21 merged commit 79195da into flutter-tizen:webview_devel Dec 24, 2020
bwikbs pushed a commit to bwikbs/plugins that referenced this pull request Jan 21, 2021
@seungsoo47 @bwikbs
Change method name's first letter (flutter-tizen#13)
5fa4b2f 
* According to convention, I change the method name's the first letter from lower case to upper case.
@swift-kim swift-kim changed the title Change method name's first letter [webview_flutter_dev] Change method name's first letter Jan 21, 2021
bwikbs pushed a commit to bwikbs/plugins that referenced this pull request Jan 27, 2021
@seungsoo47 @bwikbs
Change method name's first letter (flutter-tizen#13)
e988cf0 
* According to convention, I change the method name's the first letter from lower case to upper case.
bwikbs pushed a commit to bwikbs/plugins that referenced this pull request Mar 29, 2021
@seungsoo47 @bwikbs
Change method name's first letter (flutter-tizen#13)
cbfd4d3 
* According to convention, I change the method name's the first letter from lower case to upper case.
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Mar 29, 2021
@bwikbs @seungsoo47
[webview_flutter] Add webview_flutter_tizen package
ba5dc06 
* This PR is created from the PR below:
2bfc038 [webview_flutter] Update README and pubspec (flutter-tizen#53)
bdd6a15 [webview_flutter] Enable intergation test (flutter-tizen#52)
18da2a6 [webview_flutter] Update code by flutter version-up (flutter-tizen#49)
1b6eeed [webview_flutter] Handle CompositionEvent (flutter-tizen#47)
791511e [webview_flutter] Optimize tbm allocation (flutter-tizen#42)
7059ce2 [webview_flutter] Add cookie and scroll APIs (flutter-tizen#40)
c5a8930 Add some APIs (flutter-tizen#37)
3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (flutter-tizen#36)
42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (flutter-tizen#31)
749930e [webview_flutter] Update LWE (flutter-tizen#28)
9e26386 [webview_flutter] Implement addJavascriptChannels() (flutter-tizen#27)
6a34ae0 [webview_flutter] Update LWE (flutter-tizen#26)
a438093 [webview_flutter] Add evaluateJavascript() function (flutter-tizen#25)
0d2c271 [webview_flutter] Update webview to be focused (flutter-tizen#19)
b02b245 Enable IMF on Webview (flutter-tizen#17)
571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (flutter-tizen#15)
3413964 [webview_flutter_dev] Enable gl compositor at LWE (flutter-tizen#14)
e988cf0 Change method name's first letter (flutter-tizen#13)
cb8ee9b Handle key events for tizen webview (flutter-tizen#11)
44987de [webview_flutter] Add webview_flutter initial package (flutter-tizen#7)

Co-authored-by: MuHong Byun <[email protected]>
Co-authored-by: Seungsoo Lee <[email protected]>
@seungsoo47 seungsoo47 mentioned this pull request Mar 29, 2021
Merged
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Mar 29, 2021
@bwikbs @seungsoo47
[webview_flutter] Add webview_flutter_tizen package
573553c 
* This PR is created from the PR below:
2bfc038 [webview_flutter] Update README and pubspec (flutter-tizen#53)
bdd6a15 [webview_flutter] Enable intergation test (flutter-tizen#52)
18da2a6 [webview_flutter] Update code by flutter version-up (flutter-tizen#49)
1b6eeed [webview_flutter] Handle CompositionEvent (flutter-tizen#47)
791511e [webview_flutter] Optimize tbm allocation (flutter-tizen#42)
7059ce2 [webview_flutter] Add cookie and scroll APIs (flutter-tizen#40)
c5a8930 Add some APIs (flutter-tizen#37)
3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (flutter-tizen#36)
42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (flutter-tizen#31)
749930e [webview_flutter] Update LWE (flutter-tizen#28)
9e26386 [webview_flutter] Implement addJavascriptChannels() (flutter-tizen#27)
6a34ae0 [webview_flutter] Update LWE (flutter-tizen#26)
a438093 [webview_flutter] Add evaluateJavascript() function (flutter-tizen#25)
0d2c271 [webview_flutter] Update webview to be focused (flutter-tizen#19)
b02b245 Enable IMF on Webview (flutter-tizen#17)
571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (flutter-tizen#15)
3413964 [webview_flutter_dev] Enable gl compositor at LWE (flutter-tizen#14)
e988cf0 Change method name's first letter (flutter-tizen#13)
cb8ee9b Handle key events for tizen webview (flutter-tizen#11)
44987de [webview_flutter] Add webview_flutter initial package (flutter-tizen#7)

Co-authored-by: MuHong Byun <[email protected]>
Co-authored-by: Seungsoo Lee <[email protected]>
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Mar 29, 2021
@bwikbs @seungsoo47
[webview_flutter] Add webview_flutter_tizen package
b3d8c5a 
* This PR is created from the PR below:
2bfc038 [webview_flutter] Update README and pubspec (flutter-tizen#53)
bdd6a15 [webview_flutter] Enable intergation test (flutter-tizen#52)
18da2a6 [webview_flutter] Update code by flutter version-up (flutter-tizen#49)
1b6eeed [webview_flutter] Handle CompositionEvent (flutter-tizen#47)
791511e [webview_flutter] Optimize tbm allocation (flutter-tizen#42)
7059ce2 [webview_flutter] Add cookie and scroll APIs (flutter-tizen#40)
c5a8930 Add some APIs (flutter-tizen#37)
3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (flutter-tizen#36)
42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (flutter-tizen#31)
749930e [webview_flutter] Update LWE (flutter-tizen#28)
9e26386 [webview_flutter] Implement addJavascriptChannels() (flutter-tizen#27)
6a34ae0 [webview_flutter] Update LWE (flutter-tizen#26)
a438093 [webview_flutter] Add evaluateJavascript() function (flutter-tizen#25)
0d2c271 [webview_flutter] Update webview to be focused (flutter-tizen#19)
b02b245 Enable IMF on Webview (flutter-tizen#17)
571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (flutter-tizen#15)
3413964 [webview_flutter_dev] Enable gl compositor at LWE (flutter-tizen#14)
e988cf0 Change method name's first letter (flutter-tizen#13)
cb8ee9b Handle key events for tizen webview (flutter-tizen#11)
44987de [webview_flutter] Add webview_flutter initial package (flutter-tizen#7)

Co-authored-by: MuHong Byun <[email protected]>
Co-authored-by: Seungsoo Lee <[email protected]>
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Mar 30, 2021
@bwikbs @seungsoo47
[webview_flutter] Add webview_flutter_tizen package
eeb05e5 
* This PR is created from the PR below:
2bfc038 [webview_flutter] Update README and pubspec (flutter-tizen#53)
bdd6a15 [webview_flutter] Enable intergation test (flutter-tizen#52)
18da2a6 [webview_flutter] Update code by flutter version-up (flutter-tizen#49)
1b6eeed [webview_flutter] Handle CompositionEvent (flutter-tizen#47)
791511e [webview_flutter] Optimize tbm allocation (flutter-tizen#42)
7059ce2 [webview_flutter] Add cookie and scroll APIs (flutter-tizen#40)
c5a8930 Add some APIs (flutter-tizen#37)
3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (flutter-tizen#36)
42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (flutter-tizen#31)
749930e [webview_flutter] Update LWE (flutter-tizen#28)
9e26386 [webview_flutter] Implement addJavascriptChannels() (flutter-tizen#27)
6a34ae0 [webview_flutter] Update LWE (flutter-tizen#26)
a438093 [webview_flutter] Add evaluateJavascript() function (flutter-tizen#25)
0d2c271 [webview_flutter] Update webview to be focused (flutter-tizen#19)
b02b245 Enable IMF on Webview (flutter-tizen#17)
571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (flutter-tizen#15)
3413964 [webview_flutter_dev] Enable gl compositor at LWE (flutter-tizen#14)
e988cf0 Change method name's first letter (flutter-tizen#13)
cb8ee9b Handle key events for tizen webview (flutter-tizen#11)
44987de [webview_flutter] Add webview_flutter initial package (flutter-tizen#7)

Co-authored-by: MuHong Byun <[email protected]>
Co-authored-by: Seungsoo Lee <[email protected]>
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Mar 31, 2021
@bwikbs @seungsoo47
[webview_flutter] Add webview_flutter_tizen package
fe18993 
* This PR is created from the PR below:
2bfc038 [webview_flutter] Update README and pubspec (flutter-tizen#53)
bdd6a15 [webview_flutter] Enable intergation test (flutter-tizen#52)
18da2a6 [webview_flutter] Update code by flutter version-up (flutter-tizen#49)
1b6eeed [webview_flutter] Handle CompositionEvent (flutter-tizen#47)
791511e [webview_flutter] Optimize tbm allocation (flutter-tizen#42)
7059ce2 [webview_flutter] Add cookie and scroll APIs (flutter-tizen#40)
c5a8930 Add some APIs (flutter-tizen#37)
3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (flutter-tizen#36)
42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (flutter-tizen#31)
749930e [webview_flutter] Update LWE (flutter-tizen#28)
9e26386 [webview_flutter] Implement addJavascriptChannels() (flutter-tizen#27)
6a34ae0 [webview_flutter] Update LWE (flutter-tizen#26)
a438093 [webview_flutter] Add evaluateJavascript() function (flutter-tizen#25)
0d2c271 [webview_flutter] Update webview to be focused (flutter-tizen#19)
b02b245 Enable IMF on Webview (flutter-tizen#17)
571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (flutter-tizen#15)
3413964 [webview_flutter_dev] Enable gl compositor at LWE (flutter-tizen#14)
e988cf0 Change method name's first letter (flutter-tizen#13)
cb8ee9b Handle key events for tizen webview (flutter-tizen#11)
44987de [webview_flutter] Add webview_flutter initial package (flutter-tizen#7)

Co-authored-by: MuHong Byun <[email protected]>
Co-authored-by: Seungsoo Lee <[email protected]>
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Apr 1, 2021
@bwikbs @seungsoo47
[webview_flutter] Add webview_flutter_tizen package
4ed2ec6 
* This PR is created from the PR below:
2bfc038 [webview_flutter] Update README and pubspec (flutter-tizen#53)
bdd6a15 [webview_flutter] Enable intergation test (flutter-tizen#52)
18da2a6 [webview_flutter] Update code by flutter version-up (flutter-tizen#49)
1b6eeed [webview_flutter] Handle CompositionEvent (flutter-tizen#47)
791511e [webview_flutter] Optimize tbm allocation (flutter-tizen#42)
7059ce2 [webview_flutter] Add cookie and scroll APIs (flutter-tizen#40)
c5a8930 Add some APIs (flutter-tizen#37)
3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (flutter-tizen#36)
42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (flutter-tizen#31)
749930e [webview_flutter] Update LWE (flutter-tizen#28)
9e26386 [webview_flutter] Implement addJavascriptChannels() (flutter-tizen#27)
6a34ae0 [webview_flutter] Update LWE (flutter-tizen#26)
a438093 [webview_flutter] Add evaluateJavascript() function (flutter-tizen#25)
0d2c271 [webview_flutter] Update webview to be focused (flutter-tizen#19)
b02b245 Enable IMF on Webview (flutter-tizen#17)
571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (flutter-tizen#15)
3413964 [webview_flutter_dev] Enable gl compositor at LWE (flutter-tizen#14)
e988cf0 Change method name's first letter (flutter-tizen#13)
cb8ee9b Handle key events for tizen webview (flutter-tizen#11)
44987de [webview_flutter] Add webview_flutter initial package (flutter-tizen#7)

Co-authored-by: MuHong Byun <[email protected]>
Co-authored-by: Seungsoo Lee <[email protected]>
seungsoo47 added a commit to seungsoo47/plugins that referenced this pull request Apr 1, 2021
@bwikbs @seungsoo47
[webview_flutter] Add webview_flutter_tizen package
4e01af6 
* This PR is created from the PR below:
2bfc038 [webview_flutter] Update README and pubspec (flutter-tizen#53)
bdd6a15 [webview_flutter] Enable intergation test (flutter-tizen#52)
18da2a6 [webview_flutter] Update code by flutter version-up (flutter-tizen#49)
1b6eeed [webview_flutter] Handle CompositionEvent (flutter-tizen#47)
791511e [webview_flutter] Optimize tbm allocation (flutter-tizen#42)
7059ce2 [webview_flutter] Add cookie and scroll APIs (flutter-tizen#40)
c5a8930 Add some APIs (flutter-tizen#37)
3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (flutter-tizen#36)
42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (flutter-tizen#31)
749930e [webview_flutter] Update LWE (flutter-tizen#28)
9e26386 [webview_flutter] Implement addJavascriptChannels() (flutter-tizen#27)
6a34ae0 [webview_flutter] Update LWE (flutter-tizen#26)
a438093 [webview_flutter] Add evaluateJavascript() function (flutter-tizen#25)
0d2c271 [webview_flutter] Update webview to be focused (flutter-tizen#19)
b02b245 Enable IMF on Webview (flutter-tizen#17)
571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (flutter-tizen#15)
3413964 [webview_flutter_dev] Enable gl compositor at LWE (flutter-tizen#14)
e988cf0 Change method name's first letter (flutter-tizen#13)
cb8ee9b Handle key events for tizen webview (flutter-tizen#11)
44987de [webview_flutter] Add webview_flutter initial package (flutter-tizen#7)

Co-authored-by: MuHong Byun <[email protected]>
Co-authored-by: Seungsoo Lee <[email protected]>
bwikbs added a commit that referenced this pull request Apr 8, 2021
@seungsoo47 @bwikbs
[webview_flutter] Add webview_flutter_tizen package (#54)
f373b7c 
* [webview_flutter] Add webview_flutter_tizen package

* This PR is created from the PR below:
2bfc038 [webview_flutter] Update README and pubspec (#53)
bdd6a15 [webview_flutter] Enable intergation test (#52)
18da2a6 [webview_flutter] Update code by flutter version-up (#49)
1b6eeed [webview_flutter] Handle CompositionEvent (#47)
791511e [webview_flutter] Optimize tbm allocation (#42)
7059ce2 [webview_flutter] Add cookie and scroll APIs (#40)
c5a8930 Add some APIs (#37)
3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (#36)
42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (#31)
749930e [webview_flutter] Update LWE (#28)
9e26386 [webview_flutter] Implement addJavascriptChannels() (#27)
6a34ae0 [webview_flutter] Update LWE (#26)
a438093 [webview_flutter] Add evaluateJavascript() function (#25)
0d2c271 [webview_flutter] Update webview to be focused (#19)
b02b245 Enable IMF on Webview (#17)
571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (#15)
3413964 [webview_flutter_dev] Enable gl compositor at LWE (#14)
e988cf0 Change method name's first letter (#13)
cb8ee9b Handle key events for tizen webview (#11)
44987de [webview_flutter] Add webview_flutter initial package (#7)

Co-authored-by: MuHong Byun <[email protected]>
Co-authored-by: Seungsoo Lee <[email protected]>

* [webview_flutter] Update manifest file and remove unnecessary code

* Replace tabs to spaces in the manifest file
* Fix broken READEME.md
* Remove unnecessary code

* [webview_flutter] Update initailization code

* In accordance with the guideline, I have updated the initialization code.

* Fix integration test bug

* Fix bugs for data files and key events

* Data files will be created in application's private area.
* Key event including Shift key value will be handled properly.

* Apply latest flutter-tizen

* Because the latest flutter-tizen supports automatic copy function of plugin-dependent libraries,
  I updated a prof file and removed a library using in this plugin.

Co-authored-by: MuHong Byun <[email protected]>
@xiaowei-guan xiaowei-guan mentioned this pull request Nov 2, 2021
Closed
@xiaowei-guan xiaowei-guan mentioned this pull request Feb 13, 2023
Closed
@AMarozzi AMarozzi mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrto21 bbrto21 bbrto21 approved these changes

@bwikbs bwikbs bwikbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seungsoo47 @bwikbs @bbrto21