Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native window handle to platform view #136

Merged
merged 2 commits into from
Jul 11, 2021
Merged

Add native window handle to platform view #136

merged 2 commits into from
Jul 11, 2021

Conversation

bwikbs
Copy link
Member

@bwikbs bwikbs commented Jul 8, 2021

  • This is a preparation to independently handle something(e.g. imf) in platform view.

@bwikbs
Add native window handle to platform view
ae11169 
* This is a preparation to independently handle something(e.g. imf) in platform view.

Signed-off-by: MuHong Byun <[email protected]>
@bwikbs bwikbs mentioned this pull request Jul 8, 2021
Closed
@bwikbs
Apply review's comment
18de643 
Signed-off-by: MuHong Byun <[email protected]>
swift-kim
swift-kim reviewed Jul 8, 2021
View reviewed changes
shell/platform/tizen/tizen_renderer_evas_gl.cc
@@ -569,6 +569,10 @@ uintptr_t TizenRendererEvasGL::GetWindowId() {
ecore_evas_ecore_evas_get(evas_object_evas_get(evas_window_)));
}

void* TizenRendererEvasGL::GetWindowHandle() {
return nullptr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional or just unimplemented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's half and half 😄
Evasgl version is not implemented yet.. so This is for preventing tricky issues.

@bbrto21
Copy link

bbrto21 commented Jul 8, 2021

  • This is a preparation to independently handle something(e.g. imf) in platform view.

I've been waiting for this for a long time. Thank you so much.

bbrto21
bbrto21 approved these changes Jul 9, 2021
View reviewed changes
Copy link

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwikbs bwikbs merged commit eafde6a into flutter-tizen:flutter-2.2.1-tizen Jul 11, 2021
@swift-kim swift-kim mentioned this pull request Jul 11, 2021
Merged
swift-kim pushed a commit that referenced this pull request Sep 27, 2021
@bwikbs @swift-kim
Add native window handle to platform view (#136)
ead9a98 
* Add native window handle to platform view

* This is a preparation to independently handle something(e.g. imf) in platform view.

Signed-off-by: MuHong Byun <[email protected]>

* Apply review's comment

Signed-off-by: MuHong Byun <[email protected]>
swift-kim pushed a commit that referenced this pull request Nov 14, 2021
@bwikbs @swift-kim
Add native window handle to platform view (#136)
b6d8f40 
* Add native window handle to platform view

* This is a preparation to independently handle something(e.g. imf) in platform view.

Signed-off-by: MuHong Byun <[email protected]>

* Apply review's comment

Signed-off-by: MuHong Byun <[email protected]>
swift-kim pushed a commit that referenced this pull request Dec 9, 2021
@bwikbs @swift-kim
Add native window handle to platform view (#136)
2993133 
* Add native window handle to platform view

* This is a preparation to independently handle something(e.g. imf) in platform view.

Signed-off-by: MuHong Byun <[email protected]>

* Apply review's comment

Signed-off-by: MuHong Byun <[email protected]>
swift-kim pushed a commit that referenced this pull request Dec 17, 2021
@bwikbs @swift-kim
Add native window handle to platform view (#136)
9d56c35 
* Add native window handle to platform view

* This is a preparation to independently handle something (e.g. imf) in platform view.

* Apply review's comment

Signed-off-by: MuHong Byun <[email protected]>
swift-kim pushed a commit that referenced this pull request Feb 7, 2022
@bwikbs @swift-kim
Add native window handle to platform view (#136)
63a95fa 
* Add native window handle to platform view

* This is a preparation to independently handle something (e.g. imf) in platform view.

* Apply review's comment

Signed-off-by: MuHong Byun <[email protected]>
swift-kim pushed a commit that referenced this pull request Feb 11, 2022
@bwikbs @swift-kim
Add native window handle to platform view (#136)
17d3cf4 
* Add native window handle to platform view

* This is a preparation to independently handle something (e.g. imf) in platform view.

* Apply review's comment

Signed-off-by: MuHong Byun <[email protected]>
swift-kim pushed a commit that referenced this pull request May 12, 2022
@bwikbs @swift-kim
Add native window handle to platform view (#136)
5eddbc1 
* Add native window handle to platform view

* This is a preparation to independently handle something (e.g. imf) in platform view.

* Apply review's comment

Signed-off-by: MuHong Byun <[email protected]>
swift-kim pushed a commit that referenced this pull request Aug 5, 2022
@bwikbs @swift-kim
Add native window handle to platform view (#136)
d79df55 
* Add native window handle to platform view

* This is a preparation to independently handle something (e.g. imf) in platform view.

Signed-off-by: MuHong Byun <[email protected]>
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@dnfield
Fix enum typedef for older mac SDKs (#136)
999978f
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@bwikbs @swift-kim
Add native window handle to platform view (#136)
223b4bd 
* Add native window handle to platform view

* This is a preparation to independently handle something (e.g. imf) in platform view.

Signed-off-by: MuHong Byun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swift-kim swift-kim swift-kim left review comments

@bbrto21 bbrto21 bbrto21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwikbs @bbrto21 @swift-kim