feat(build): #1282 assure purity removing dir #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohaquinlop
force-pushed
the
issue-1282
branch
7 times, most recently
from
b5ad1bf to
41508c4
Compare
dsalaza4
reviewed
Jan 30, 2024
dsalaza4
reviewed
Jan 30, 2024
rohaquinlop
force-pushed
the
issue-1282
branch
from
41508c4 to
1d7681d
Compare
dsalaza4
reviewed
Jan 31, 2024
rohaquinlop
force-pushed
the
issue-1282
branch
from
1d7681d to
023b700
Compare
- Update mailmap - Set `HOME` to a temp dir - Remove `homeless-shelter` dir if it exists - Create external function to fetch all packages names from a TOML file, including the extras Approach: - Read the TOML file and get the packages. - Override the `preUnpack` function to set `HOME` to a temp dir. - Override the `overrides` function to combine, in case of conflict, the `overrides` that was passed will be the one that prevails. Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop
force-pushed
the
issue-1282
branch
from
023b700 to
8e570ae
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEto a temp dirhomeless-shelterdir if it existsnames from a TOML file, including the extras
Approach:
preUnpackfunction to setHOMEto a temp dir.overridesfunction to combine,in case of conflict, the
overridesthat was passedwill be the one that prevails.