Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac(back): #1045 remove islinux #1047

Merged
merged 1 commit into from
Mar 16, 2023
Merged

refac(back): #1045 remove islinux #1047

merged 1 commit into from
Mar 16, 2023

Conversation

jpverde
Copy link
Contributor

@jpverde jpverde commented Mar 16, 2023

  • Remove unnecessary condition over isLinux

@dsalaza4
Copy link
Contributor

Please remove warnings from https://makes.fluidattacks.com/api/extensions/node.js

@jpverde jpverde force-pushed the main branch 3 times, most recently from a173c02 to ddd4030 Compare March 16, 2023 16:57
@jpverde
Copy link
Contributor Author

jpverde commented Mar 16, 2023

Please remove warnings from https://makes.fluidattacks.com/api/extensions/node.js

Done.

@jpverde
refac(back): fluidattacks#1045 remove islinux
c43c74d 
- Remove unnecessary condition over `isLinux`
- Remove warnings on docs

Signed-off-by: John Perez <[email protected]>
@dsalaza4 dsalaza4 merged commit 6075796 into fluidattacks:main Mar 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsalaza4 dsalaza4 dsalaza4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpverde @dsalaza4